-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hyperlinks in supported terminals #37
Support hyperlinks in supported terminals #37
Conversation
…apped links with the appropriate ansi escape to shorten the output and not hyperlink multiple times per wrapped word
// @stroncium @TiagoDanin Would you be able to help review? |
@nicholaschiasson Ping :) |
Just updating, I plan to resolve all of the open discussions here soon! Sorry for the wait 😄 |
Fixed hyperlink wrap by adding the hyperlink ansi wrap opening and closing on each beginning and ending of line, respectively, where necessary. Fixed existing bug where the string 'pre' was being incorrectly indexed without considering surrogate pairs, instead deconstructed it into an array. Added test case to cover code paths where an ansi escape is used which does not match on Select Graphic Rendition or ansi hyperlink patterns. Made hyperlink test cases much more understandable.
…n supportive terminals
Addressed all discussions, but apparently support for node 8 is broken. I will look into this soon. |
Support for Node.js 8 doesn’t matter. I plan to target Node.js 10 after this PR. |
Ah whoops, I fixed it nonetheless. Up to you which style is preferable, named regex capture groups or not, but in any case I think this is ready again for review. |
Can you revert 2b6a0b4? |
This reverts commit 2b6a0b4.
Thank you :) |
Fixes #35
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor