Skip to content

Set tangent_type for AbstractLogger to NoTangent #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yebai merged 7 commits into from
Aug 27, 2025
Merged

Set tangent_type for AbstractLogger to NoTangent #710

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9a8b6b3
Initial plan
Copilot Aug 26, 2025
664fe94
Set tangent_type for Logging.ConsoleLogger to NoTangent
Copilot Aug 26, 2025
b03b8b1
Apply suggestions from code review
yebai Aug 26, 2025
2bb1d36
Merge branch 'main' into copilot/fix-b927b52d-2d90-45b6-b5a8-41632ce6…
yebai Aug 27, 2025
d31f330
Add ConsoleLogger test to verify AbstractLogger tangent type coverage
Copilot Aug 27, 2025
2b7c859
Add Base.CoreLogging.SimpleLogger to type union
yebai Aug 27, 2025
f40679f
Update test/tangents.jl
yebai Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/tangents.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,8 @@ tangent_type(::Type{<:Base.TTY}) = NoTangent

tangent_type(::Type{<:IOStream}) = NoTangent

tangent_type(::Type{<:Base.CoreLogging.AbstractLogger}) = NoTangent

function split_union_tuple_type(tangent_types)

# Create first split.
Expand Down Expand Up @@ -1353,6 +1355,7 @@ tangents, but they're unable to check that `increment!!` is correct in an absolu
(Union, NoTangent),
(UnionAll, NoTangent),
(typeof(<:), NoTangent),
(Base.CoreLogging.SimpleLogger, NoTangent),
(IOStream(""), NoTangent),
]
# Construct test cases containing circular references. These typically require multiple
Expand Down
Loading