Skip to content

CompatHelper: bump compat for JET in [weakdeps] to 0.10, (keep existing compat)#691

Merged
yebai merged 13 commits intocopilot/fix-521d0edf-b6f3-4f8f-810a-9b67505ecccafrom
compathelper/new_version/2025-08-13-00-06-23-082-00714333526
Aug 28, 2025
Merged

CompatHelper: bump compat for JET in [weakdeps] to 0.10, (keep existing compat)#691
yebai merged 13 commits intocopilot/fix-521d0edf-b6f3-4f8f-810a-9b67505ecccafrom
compathelper/new_version/2025-08-13-00-06-23-082-00714333526

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 13, 2025

This pull request changes the compat entry for the JET package from 0.9 to 0.9, 0.10.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Closes #732.

@willtebbutt willtebbutt force-pushed the compathelper/new_version/2025-08-13-00-06-23-082-00714333526 branch from 0c1733d to 158a0b3 Compare August 13, 2025 00:06
@github-actions
Copy link
Contributor Author

Mooncake.jl documentation for PR #691 is available at:
https://chalk-lab.github.io/Mooncake.jl/previews/PR691/

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/rrules/avoiding_non_differentiable_code.jl 0.00% 3 Missing ⚠️
src/tangents.jl 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor Author

github-actions bot commented Aug 13, 2025

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬──────────┬─────────────┬─────────┬─────────────┬─────────┐
│                      Label │   Primal │ Mooncake │ MooncakeFwd │  Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │   String │      String │  String │      String │  String │
├────────────────────────────┼──────────┼──────────┼─────────────┼─────────┼─────────────┼─────────┤
│                   sum_1000 │ 100.0 ns │      1.8 │         1.8 │     1.0 │        5.51 │    8.21 │
│                  _sum_1000 │ 941.0 ns │     6.65 │        1.01 │  1440.0 │        33.4 │    1.09 │
│               sum_sin_1000 │  6.54 μs │     2.24 │        1.38 │    1.69 │        10.7 │    2.23 │
│              _sum_sin_1000 │  5.07 μs │     2.71 │        2.27 │   286.0 │        13.7 │    2.58 │
│                   kron_sum │ 282.0 μs │     48.8 │        3.31 │     5.7 │       256.0 │    10.9 │
│              kron_view_sum │ 322.0 μs │     52.2 │        3.55 │    11.3 │       246.0 │    6.82 │
│      naive_map_sin_cos_exp │  2.14 μs │     2.19 │        1.41 │ missing │        7.28 │    2.35 │
│            map_sin_cos_exp │   2.1 μs │     2.47 │        1.46 │    1.51 │        6.28 │    2.92 │
│      broadcast_sin_cos_exp │  2.26 μs │     2.36 │         1.4 │    2.35 │        1.49 │    2.28 │
│                 simple_mlp │ 421.0 μs │     4.59 │        2.96 │    1.59 │        6.63 │    3.22 │
│                     gp_lml │ 565.0 μs │     4.38 │         1.5 │    2.17 │     missing │    2.81 │
│ turing_broadcast_benchmark │  1.99 ms │     3.75 │        3.02 │ missing │        24.8 │ missing │
│         large_single_block │ 380.0 ns │     4.53 │        2.03 │  4500.0 │        34.6 │    2.24 │
└────────────────────────────┴──────────┴──────────┴─────────────┴─────────┴─────────────┴─────────┘

@willtebbutt willtebbutt changed the title CompatHelper: bump compat for JET in [weakdeps] to 0.10, (keep existing compat) [DO NOT MERGE] CompatHelper: bump compat for JET in [weakdeps] to 0.10, (keep existing compat) Aug 26, 2025
@willtebbutt
Copy link
Collaborator

I forget the details, but we cannot currently upgrade to JET 0.10 (hence the failing CI above). This is something we might need to revisit in the future or, potentially, drop the JET dependency in favour of something else, as I'm not sure whether it's going to be possible to run a single version of JET on both Julia 1.10 and 1.12.

@willtebbutt willtebbutt changed the title [DO NOT MERGE] CompatHelper: bump compat for JET in [weakdeps] to 0.10, (keep existing compat) CompatHelper: bump compat for JET in [weakdeps] to 0.10, (keep existing compat) Aug 27, 2025
@willtebbutt
Copy link
Collaborator

Annoyingly it looks like compat helper with keep opening new PRs if I modify the title of this one, so I've had to change it back. Either way, please do not merge this.

@yebai yebai marked this pull request as draft August 27, 2025 10:11
@yebai
Copy link
Member

yebai commented Aug 27, 2025

For CI or testing purposes, can we leverage Julia-version-specific Manifest.toml for Julia 1.12 and beyond?

https://pkgdocs.julialang.org/v1/toml-files/#Different-Manifests-for-Different-Julia-versions

Copilot AI and others added 3 commits August 27, 2025 13:33
* Initial plan

* Set tangent_type for Logging.ConsoleLogger to NoTangent

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Apply suggestions from code review

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Add ConsoleLogger test to verify AbstractLogger tangent type coverage

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Add Base.CoreLogging.SimpleLogger to type union

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update test/tangents.jl

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>
…#707)

* Initial plan

* Add better error messages for tangent accessors when types are passed

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Hong Ge <hg344@cam.ac.uk>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>
* Tidy up error-generating methods

* Remove redundant tests

* Remove more redundant test cases

* Bump patch version
@willtebbutt
Copy link
Collaborator

I don't think so, because we don't commit a manifest to the package (and I definitely don't think we should start doing so).

araujoms and others added 7 commits August 27, 2025 18:23
* working complex logdet

* bump version

* proper getrf! tests

* improve tests

* move tests

* generalize tests

* formatting and version

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Mateus Araújo <maltusan@gmail.com>
Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
* Initial plan

* Add DiffEq integration test with original example from issue

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Finalize DiffEq integration test with comprehensive structure

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Remove @info and @test_broken statements to reduce clutter

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>
* Initial plan

* Fix DiffEq integration test by testing reverse mode only

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* formatting

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>
Co-authored-by: Hong Ge <hg344@cam.ac.uk>
* Initial plan

* Update IR docs title and remove duplication, add comparison section

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Address PR feedback: update title and simplify Optics reference

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Restore IRCode field details that were incorrectly removed

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>
Copilot AI and others added 2 commits August 28, 2025 14:15
#733)

* Fix changelog version (#693)

* remove `const M` (#696)

* remove const M

* fix formatting

* Update Project.toml

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update README.md (#697)

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* minimal print io output (#699)

* minimal print

* vers bump

* remove prev tests

* include show in derived

* Update algorithmic_differentiation.md (#703)

I noticed a typo. I likely won't look at this again for a week or so, so please feel free to merge for me.

Signed-off-by: Will Tebbutt <3628294+willtebbutt@users.noreply.github.com>

* Fix 660 (#705)

* Fix + tests

* Bump patch version

* Use _stable_typeof directly

* Comment on the use of _stable_typeof

* Extend arrayify for complex numbers (#706)

* Fix + tests

* Bump patch version

* Use _stable_typeof directly

* Add arrayify tests

* Widen permitted types

* Bump patch version again

* Formatting

* Uncomment blas tests

* Create contribution guidelines in copilot-instructions.md (#713)

Added contribution guidelines for the automatic differentiation package.

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Set tangent_type for AbstractLogger to NoTangent (#710)

* Initial plan

* Set tangent_type for Logging.ConsoleLogger to NoTangent

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Apply suggestions from code review

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Add ConsoleLogger test to verify AbstractLogger tangent type coverage

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Add Base.CoreLogging.SimpleLogger to type union

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update test/tangents.jl

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Add better error messages for tangent accessors when types are passed (#707)

* Initial plan

* Add better error messages for tangent accessors when types are passed

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Hong Ge <hg344@cam.ac.uk>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Tidy up  (#715)

* Tidy up error-generating methods

* Remove redundant tests

* Remove more redundant test cases

* Bump patch version

* add rule for complex logdet (#664)

* working complex logdet

* bump version

* proper getrf! tests

* improve tests

* move tests

* generalize tests

* formatting and version

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Mateus Araújo <maltusan@gmail.com>
Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Delete .github/copilot-instructions.md (#722)

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Uncomment b_binv_test_case for PlanarLayer (#727)

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Add DiffEq integration test for Mooncake (#726)

* Initial plan

* Add DiffEq integration test with original example from issue

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Finalize DiffEq integration test with comprehensive structure

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Remove @info and @test_broken statements to reduce clutter

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* fix formatting (#728)

* Fix DiffEq integration test by restricting to reverse mode only (#731)

* Initial plan

* Fix DiffEq integration test by testing reverse mode only

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* formatting

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>
Co-authored-by: Hong Ge <hg344@cam.ac.uk>

* Fix IR docs duplication and improve documentation structure (#718)

* Initial plan

* Update IR docs title and remove duplication, add comparison section

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Address PR feedback: update title and simplify Optics reference

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Restore IRCode field details that were incorrectly removed

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Initial plan

* Add Julia version-dependent JET version selection to CI workflow

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Improve JET version handling to support complex constraints and remove need for explicit version on Julia 1.12+

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Apply suggestions from code review

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update CI.yml

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Will Tebbutt <3628294+willtebbutt@users.noreply.github.com>
Signed-off-by: Mateus Araújo <maltusan@gmail.com>
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Co-authored-by: Astitva Aggarwal <84859349+AstitvaAggarwal@users.noreply.github.com>
Co-authored-by: Will Tebbutt <3628294+willtebbutt@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Hong Ge <hg344@cam.ac.uk>
Co-authored-by: Mateus Araújo <maltusan@gmail.com>
…-082-00714333526

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
@yebai yebai marked this pull request as ready for review August 28, 2025 13:16
@yebai yebai changed the base branch from main to copilot/fix-521d0edf-b6f3-4f8f-810a-9b67505eccca August 28, 2025 17:01
@yebai yebai merged commit b4fb31c into copilot/fix-521d0edf-b6f3-4f8f-810a-9b67505eccca Aug 28, 2025
88 of 90 checks passed
@yebai yebai deleted the compathelper/new_version/2025-08-13-00-06-23-082-00714333526 branch August 28, 2025 17:01
sunxd3 pushed a commit that referenced this pull request Nov 11, 2025
* Initial plan

* Add Julia v1.12 compatibility for BBCode and IR infrastructure

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Add 'pre' version to CI workflow

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Fix inlining_policy function name for Julia v1.12+ compatibility and format code

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* CompatHelper: bump compat for JET in [weakdeps] to 0.10, (keep existing compat) (#691)

* CompatHelper: bump compat for JET in [weakdeps] to 0.10, (keep existing compat)

* Set tangent_type for AbstractLogger to NoTangent (#710)

* Initial plan

* Set tangent_type for Logging.ConsoleLogger to NoTangent

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Apply suggestions from code review

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Add ConsoleLogger test to verify AbstractLogger tangent type coverage

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Add Base.CoreLogging.SimpleLogger to type union

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update test/tangents.jl

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Add better error messages for tangent accessors when types are passed (#707)

* Initial plan

* Add better error messages for tangent accessors when types are passed

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Hong Ge <hg344@cam.ac.uk>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Tidy up  (#715)

* Tidy up error-generating methods

* Remove redundant tests

* Remove more redundant test cases

* Bump patch version

* add rule for complex logdet (#664)

* working complex logdet

* bump version

* proper getrf! tests

* improve tests

* move tests

* generalize tests

* formatting and version

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Mateus Araújo <maltusan@gmail.com>
Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Delete .github/copilot-instructions.md (#722)

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Uncomment b_binv_test_case for PlanarLayer (#727)

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Add DiffEq integration test for Mooncake (#726)

* Initial plan

* Add DiffEq integration test with original example from issue

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Finalize DiffEq integration test with comprehensive structure

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Remove @info and @test_broken statements to reduce clutter

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* fix formatting (#728)

* Fix DiffEq integration test by restricting to reverse mode only (#731)

* Initial plan

* Fix DiffEq integration test by testing reverse mode only

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* formatting

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>
Co-authored-by: Hong Ge <hg344@cam.ac.uk>

* Fix IR docs duplication and improve documentation structure (#718)

* Initial plan

* Update IR docs title and remove duplication, add comparison section

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Address PR feedback: update title and simplify Optics reference

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Restore IRCode field details that were incorrectly removed

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Add robust Julia version-dependent JET version handling to CI workflow (#733)

* Fix changelog version (#693)

* remove `const M` (#696)

* remove const M

* fix formatting

* Update Project.toml

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update README.md (#697)

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* minimal print io output (#699)

* minimal print

* vers bump

* remove prev tests

* include show in derived

* Update algorithmic_differentiation.md (#703)

I noticed a typo. I likely won't look at this again for a week or so, so please feel free to merge for me.

Signed-off-by: Will Tebbutt <3628294+willtebbutt@users.noreply.github.com>

* Fix 660 (#705)

* Fix + tests

* Bump patch version

* Use _stable_typeof directly

* Comment on the use of _stable_typeof

* Extend arrayify for complex numbers (#706)

* Fix + tests

* Bump patch version

* Use _stable_typeof directly

* Add arrayify tests

* Widen permitted types

* Bump patch version again

* Formatting

* Uncomment blas tests

* Create contribution guidelines in copilot-instructions.md (#713)

Added contribution guidelines for the automatic differentiation package.

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Set tangent_type for AbstractLogger to NoTangent (#710)

* Initial plan

* Set tangent_type for Logging.ConsoleLogger to NoTangent

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Apply suggestions from code review

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Add ConsoleLogger test to verify AbstractLogger tangent type coverage

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Add Base.CoreLogging.SimpleLogger to type union

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update test/tangents.jl

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Add better error messages for tangent accessors when types are passed (#707)

* Initial plan

* Add better error messages for tangent accessors when types are passed

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Hong Ge <hg344@cam.ac.uk>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Tidy up  (#715)

* Tidy up error-generating methods

* Remove redundant tests

* Remove more redundant test cases

* Bump patch version

* add rule for complex logdet (#664)

* working complex logdet

* bump version

* proper getrf! tests

* improve tests

* move tests

* generalize tests

* formatting and version

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Mateus Araújo <maltusan@gmail.com>
Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Delete .github/copilot-instructions.md (#722)

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Uncomment b_binv_test_case for PlanarLayer (#727)

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Add DiffEq integration test for Mooncake (#726)

* Initial plan

* Add DiffEq integration test with original example from issue

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Finalize DiffEq integration test with comprehensive structure

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Remove @info and @test_broken statements to reduce clutter

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* fix formatting (#728)

* Fix DiffEq integration test by restricting to reverse mode only (#731)

* Initial plan

* Fix DiffEq integration test by testing reverse mode only

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* formatting

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>
Co-authored-by: Hong Ge <hg344@cam.ac.uk>

* Fix IR docs duplication and improve documentation structure (#718)

* Initial plan

* Update IR docs title and remove duplication, add comparison section

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Address PR feedback: update title and simplify Optics reference

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Restore IRCode field details that were incorrectly removed

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Initial plan

* Add Julia version-dependent JET version selection to CI workflow

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Improve JET version handling to support complex constraints and remove need for explicit version on Julia 1.12+

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Apply suggestions from code review

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update CI.yml

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Will Tebbutt <3628294+willtebbutt@users.noreply.github.com>
Signed-off-by: Mateus Araújo <maltusan@gmail.com>
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Co-authored-by: Astitva Aggarwal <84859349+AstitvaAggarwal@users.noreply.github.com>
Co-authored-by: Will Tebbutt <3628294+willtebbutt@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Hong Ge <hg344@cam.ac.uk>
Co-authored-by: Mateus Araújo <maltusan@gmail.com>

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Mateus Araújo <maltusan@gmail.com>
Signed-off-by: Will Tebbutt <3628294+willtebbutt@users.noreply.github.com>
Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>
Co-authored-by: Hong Ge <hg344@cam.ac.uk>
Co-authored-by: Will Tebbutt <3628294+willtebbutt@users.noreply.github.com>
Co-authored-by: Mateus Araújo <maltusan@gmail.com>
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
Co-authored-by: Astitva Aggarwal <84859349+AstitvaAggarwal@users.noreply.github.com>

* Prevent exporting names already declared as public

This is disallowed by the language and results in an error.

* Extend required interface CC.add_edges_impl!

* Adapt to stackless inference change (using CC.Future etc)

* Always return a boolean from `src_inlining_policy`

* Fix relocation of a few Experimental functions to CC

* Fix `_ir_abstract_constant_propagation` rename

* Adjust to `ir_abstract_constant_propagation` changes

* Support `invoke` CodeInstance arguments

* Adjust to opaque macro behavior change

* Define better slotnames for debugging

* Fix opaque closure construction

* Adjust to 1.12 opaque closure creation change

* More fixes

* Fix IRCode construction bug

* Adjust to binding changes for primal type extraction

* Rules for new intrinsics

* Set appropriate world bounds on the `CodeInfo`

* Optimize opaque closures

* Avoid failures on <1.12

* Don't attempt to set bounds if no inferred code is available

* More <1.12 fixes

* Don't optimize if IR interp can't be performed

* More fixes/tests

* Revert use of `Base.allocations`

It is not defined on <1.12, and the macro form seems fine.

* Fix bad line info information

* Make line info logic more robust, fix a few more things

* [WIP] add rules for `svec` and `_svec_len`

* Don't add _svec_len rule for < 1.12

* Try to avoid error in IRInterp

* Allow type unstability for `compute_oc_signature`

* Attempt to fix allocations

* Still use the same Tuple type for < 1.12

* Unconditionally set ir.argtypes[1] to an accurate Tuple

* Fix `primal_type` bug

* Fix construction error for IRCode

* Fix more issues

* Discard unwanted change

* Make version check static

* Add some @zero_derivatives for logging (#815)

* Mark Base.fixup_stdlib_path as having @zero_derivative

This comes up because in Julia 1.12 logmsg_code gets the folder of
Core.Compiler if needed to resolve paths, which results in a ccall
with no known rule. See
JuliaLang/julia#57274.

* Make Base.CoreLogging.handle_message_nothrow as having @zero_derivative

This comes up in logmsg_code, because in Julia v1.12
handle_message_nothrow got a try-catch structure, which creates an
UpsilonNode that Mooncake can't handle.

* Update avoiding_non_differentiable_code.jl

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* fix format

* Fix handle_message_nothrow @zero_derivative rule

* Improve a comment

* Fix duplicate svec rule after merge

* Remove JET version adjustment from CI workflow

Removed JET version adjustment step based on Julia version from CI workflow.

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Fix typo in 1.12-

* Also test buildkit and ext on 1.12?

* Use an eval to avoid duplicating BBCode

* Remove useless line (thanks Copilot)

* Update get_primal_type for GlobalRef

* Update isva comment

* Require Julia 1.12.1 or newer

* Fix stdin reference not working in 1.11

* Update patch_for_319 following Julia 1.12 changes

* Binding partitions are lazily populated!

* Set the IR's valid worlds to only the interpreter world (#832)

* Try to set the IR valid worlds to only the interpreter world

* Add explanation to set_valid_worlds!

* Tweak comment

* Update dispatch_doctor.jl

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Import _Utils from DispatchDoctor in tests

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* reformat

* Use a single world for inference

* Disable JET tests for Julia 1.12 temporarily.

Julia 1.12 has a few Base functions that are not type-stable, causing false-positive JET test failures in Mooncake.

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* re-enable JET test for Julia 1.12 and format.

* Mark compute_oc_signature as unstable

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Add documentation for resolve_unbound_globalrefs function

Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>

* Add unstable block for version-specific functions

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update allocation tests for Julia version compatibility

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update frule allocation tests for Julia version compatibility

* refactor count_allocs

* Update JET version to include 0.11 (#841)

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* fix allocation counts for primals (plus `_new_` frule) (#843)

* Fix allocation counters for `sum` and `rand` primals

This fixes:
- `sum(abs2, randn(11))` on 1.12
- `rand(rng, Float64)` on 1.10 and 1.11

* Use `eval` instead

* Fix for `_new_` (I think)

* Just get rid of the varargs in count_allocs

* Add a warning

* Fix all the horrible edge cases

* Final fixes (please don't let me down)

* Format

* Skip certain stability and performance tests for 1.12 (#844)

* Refactor stability rules for Float types in Julia

Updated stability and allocation rules for Float types based on Julia version.

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Remove Float16 cases from test cases

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update avoiding_non_differentiable_code.jl

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* reformat

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Clarify GlobalRef resolution docs

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Fix for TwicePrecision allocs (#845)

* Add rules for LAPACK.lacpy! and BLAS.trsv! (#839)

* Add rules for LAPACK.lacpy!

* LAPACK.lacpy! is exclusive to Julia 1.11+

* Add rule for BLAS.trsv!

* Isolate sensitive trsm! rule

---------

Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* re-enable F16, only F32 and F64 are type unstable on 1.12

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>

* Update Project.toml

Co-authored-by: Markus Hauru <mhauru@turing.ac.uk>
Signed-off-by: Bruno Ploumhans <13494793+Technici4n@users.noreply.github.com>

---------

Signed-off-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Signed-off-by: Mateus Araújo <maltusan@gmail.com>
Signed-off-by: Will Tebbutt <3628294+willtebbutt@users.noreply.github.com>
Signed-off-by: Bruno Ploumhans <13494793+Technici4n@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yebai <3279477+yebai@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
Co-authored-by: Hong Ge <hg344@cam.ac.uk>
Co-authored-by: Will Tebbutt <3628294+willtebbutt@users.noreply.github.com>
Co-authored-by: Mateus Araújo <maltusan@gmail.com>
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
Co-authored-by: Astitva Aggarwal <84859349+AstitvaAggarwal@users.noreply.github.com>
Co-authored-by: serenity4 <cedric.bel@hotmail.fr>
Co-authored-by: Markus Hauru <mhauru@turing.ac.uk>
Co-authored-by: Bruno Ploumhans <13494793+Technici4n@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let CI determine JET.jl version bound

5 participants