[C++20/DR] Fix compile error for equality in rewrite expressions #6863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for taking so long to get back to this. Thank you for the PR, I am trying to re-run pipelines to see why |
|
@QuellaZhang do yo mind if I rebase it on top of latest changes? That would force-change your fork. Or can you rebase it yourself? I'm not sure why builds are not re-running (history is gone), maybe that would restart them. Then change looks reasonable overall, though we need to try to get to the bottom of CI failures. On a similar note, can you sign contribution agreement? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the MSVC team implemented P2468R2 The Equality Operator You Are Looking For, we got an error compiling ChakraCore with /std:c++latest on MSVC, now it is fixed.
Error message:
F:\gitP\microsoft\ChakraCore\lib\Runtime\Language\SimdUtils.h(70,16): error C2666: '_SIMDValue::operator ==': overloaded functions have similar conversionsF:\gitP\microsoft\ChakraCore\lib\Runtime\Language\SimdUtils.h(48,10): note: could be 'bool _SIMDValue::operator ==(const _SIMDValue &)'C:\Program Files (x86)\Windows Kits\10\include\10.0.22618.0\shared\guiddef.h(192,15): note: or 'bool operator ==(const GUID &,const GUID &)'F:\gitP\microsoft\ChakraCore\lib\Runtime\Language\SimdUtils.h(48,10): note: or 'bool _SIMDValue::operator ==(const _SIMDValue &)' [synthesized expression 'y == x']C:\Program Files (x86)\Windows Kits\10\include\10.0.22618.0\shared\guiddef.h(192,15): note: or 'bool operator ==(const GUID &,const GUID &)' [synthesized expression 'y == x']F:\gitP\microsoft\ChakraCore\lib\Runtime\Language\SimdUtils.h(70,16): note: while trying to match the argument list '(_SIMDValue, _SIMDValue)'