Unify small and medium blocks. #5071
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leirocks
reviewed
Apr 30, 2018
| @@ -563,6 +570,20 @@ SmallHeapBlockT<TBlockAttributes>::GetObjectBitDelta() | |||
| return this->objectSize / HeapConstants::ObjectGranularity; | |||
| } | |||
|
|
|||
| template <class TBlockAttributes> | |||
| __forceinline ushort | |||
| SmallHeapBlockT<TBlockAttributes>::GetAddressBitIndex(void * objectAddress, uint bucketIndex) | |||
There was a problem hiding this comment.
bucketIndex [](start = 81, length = 11)
not used?
curtisman
reviewed
May 5, 2018
| 4 64 8 | ||
| 8 128 8 | ||
| 16 256 4 | ||
| Total # of Buckets: 76 |
There was a problem hiding this comment.
The code looks fine. Have you measure what the memory impact is? Is there any other perf impact?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the small and medium block types. After this change we will have only small and large blocks. Any objects of size less than or equal to 3584 bytes will fall in the small buckets. All the objects larger than that will be allocated in large buckets. In future, we may reduce the size of objects that fall into the small bucket even further.
The alignment of objects in the small bucket is based on the actual size of the objects. Currently, this is setup as follows and can be tweaked if needed:
SizeCat <= 768 bytes are aligned to 16 bytes
SizeCat <= 1024 bytes are aligned to 32 bytes
SizeCat <= 1536 bytes are aligned to 64 bytes
SizeCat <= 2560 bytes are aligned to 128 bytes
SizeCat <= 3584 bytes are aligned to 256 bytes