Fixes for step-back with async #4796
Merged
+137
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -896,7 +896,8 @@ namespace TTD | |||
| //we moved to a new statement | |||
| Js::FunctionBody::StatementMap* pstmt = fb->GetStatementMaps()->Item(cIndex); | |||
| bool newstmt = (cIndex != cfinfo.CurrentStatementIndex && pstmt->byteCodeSpan.begin <= (int)bytecodeOffset && (int)bytecodeOffset <= pstmt->byteCodeSpan.end); | |||
| if (newstmt) | |||
| bool startUnaligned = (cfinfo.CurrentStatementIndex == -1) && (pstmt->byteCodeSpan.begin != (int)bytecodeOffset); //make sure async step back is ok | |||
There was a problem hiding this comment.
Nit: I mildly prefer testing against the positive case rather than testing the inverse of the negative case (i.e have a variable called startAligned instead).
What is expected to happen if the statement is not aligned?
I'm also unclear as to the circumstances when pstmt->byteCodeSpan.begin != byteCodeOffset- I can believe it happens but I'm not sure why it's related to async calls- can you add a clarifying comment here that speaks to that?
Nit: not your current change but since you're touching this file anyway- should this be &&? Refers to: lib/Runtime/Debug/TTExecutionInfo.cpp:883 in 5784b7b. [](commit_id = 5784b7b, deletion_comment = False) |
chakrabot
pushed a commit
that referenced
this pull request
Mar 12, 2018
Merge pull request #4796 from mrkmarron:asyncfixes19 Add missing snapshot visit location. Fix previous line logic for inline awaits.
chakrabot
pushed a commit
that referenced
this pull request
Mar 12, 2018
Merge pull request #4796 from mrkmarron:asyncfixes19 Add missing snapshot visit location. Fix previous line logic for inline awaits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing snapshot visit location.
Fix previous line logic for inline awaits.