OS#14057294: don't use param scope for jit loop bodies #4660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jit loop bodies start past the instruction that ends param scope when param and body scopes are split, leading to a Throw::FatalInternalError when there are more scope slots than param scope slots
pleath
approved these changes
Feb 8, 2018
boingoing
approved these changes
Feb 8, 2018
chakrabot
pushed a commit
that referenced
this pull request
Feb 8, 2018
…op bodies Merge pull request #4660 from sigatrev:loopScope jit loop bodies start past the instruction that ends param scope when param and body scopes are split, leading to a Throw::FatalInternalError when there are more scope slots than param scope slots
chakrabot
pushed a commit
that referenced
this pull request
Feb 8, 2018
…pe for jit loop bodies Merge pull request #4660 from sigatrev:loopScope jit loop bodies start past the instruction that ends param scope when param and body scopes are split, leading to a Throw::FatalInternalError when there are more scope slots than param scope slots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jit loop bodies start past the instruction that ends param scope when param and body scopes are split, leading to a Throw::FatalInternalError when there are more scope slots than param scope slots