xplat: build-time fixes and enabling runtime features #2487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
obastemur
commented
Feb 8, 2017
obastemur
commented
- xplat: library visibility changes [/cc nodejs-chakracore]
- osx: enable temp disabled profiling/tracking features
- osx: make 10.9 default minimum target [/cc nodejs-chakracore]
- xplat: do not static link to libstdc++ (shared)
obastemur
force-pushed
the
osx_fixes_5
branch
from
e281c14 to
6a0a7e4
Compare
Collaborator
Author
|
removed libstdc++ update from the PR but somehow unable to edit merge description.. |
Collaborator
Author
|
@dotnet-bot test OSX osx_osx_test_static |
|
|
Collaborator
Author
|
@jianchun Thanks for the review! |
chakrabot
pushed a commit
that referenced
this pull request
Feb 10, 2017
… features Merge pull request #2487 from obastemur:osx_fixes_5 - xplat: library visibility changes [/cc nodejs-chakracore] - osx: enable temp disabled profiling/tracking features - osx: make 10.9 default minimum target [/cc nodejs-chakracore] - xplat: do not static link to libstdc++ (shared)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.