xplat: make sure linker doesn't pass gluing sub libs #2460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
obastemur
commented
Feb 3, 2017
obastemur
commented
- remove unused definitions and fix mixing empty object file (context)
- make sure sub libs (static) are combined (use an empty object file)
- remove unused definitions and fix mixing empty object file (context) - make sure sub libs (static) are combined (use an empty object file)
jianchun
reviewed
Feb 3, 2017
bin/ch/WScriptJsrt.cpp
Outdated
| JsValueRef buildValue; | ||
| #ifdef _DEBUG | ||
| #define BUILD_TYPE_STRING_CH "Debug" // (O0) | ||
| #elif !defined(_DEBUG) && defined(ENABLE_DEBUG_CONFIG_OPTIONS) |
Collaborator
Author
There was a problem hiding this comment.
Yes, indeed it is. Thanks!
|
|
Collaborator
Author
|
@jianchun Thanks for the review |
chakrabot
pushed a commit
that referenced
this pull request
Feb 10, 2017
…sub libs Merge pull request #2460 from obastemur:fix_glue - remove unused definitions and fix mixing empty object file (context) - make sure sub libs (static) are combined (use an empty object file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.