android: fix va_* and cleanup pal + first output #2292
Conversation
obastemur
commented
Dec 28, 2016
obastemur
commented
obastemur
force-pushed
the
chandroid_001
branch
from
b766354 to
ea6b954
Compare
|
@dotnet-bot test Windows x86_release please |
|
Very cool! @EdMaurer FYI |
| /******************* Compiler-specific glue *******************************/ | ||
|
|
||
| #ifndef _MSC_VER | ||
| #define FEATURE_PAL_SXS 1 |
There was a problem hiding this comment.
Why is this change needed?
| #endif // !_MSC_VER | ||
|
|
||
| #if defined(_MSC_VER) || defined(__llvm__) | ||
| #define DECLSPEC_ALIGN(x) __declspec(align(x)) |
There was a problem hiding this comment.
I'm confused- __declspec(align) is a VC++ concept, no? Wasn't the ifdef that was there correct?
There was a problem hiding this comment.
We use either Clang or VC++.
| #define DECLSPEC_NORETURN PAL_NORETURN | ||
|
|
||
| #ifndef _MSC_VER | ||
| #define __assume(x) (void)0 |
There was a problem hiding this comment.
I'm trying to understand the changes to this file- is the idea basically that this file should never be built with VC++? Otherwise, for instance, this change breaks prefast, no?
There was a problem hiding this comment.
the idea basically that this file should never be built with VC++?
Yes
digitalinfinity
left a comment
digitalinfinity
left a comment
There was a problem hiding this comment.
Generally, LGTM- just have questions about the changes in Pal.h, which appear to be more than just android-specific changes
|
@digitalinfinity Thanks for the review!! |
…tput Merge pull request #2292 from obastemur:chandroid_001 <img width="225" alt="andro-chakra" src="https://cloud.githubusercontent.com/assets/4390745/21525939/d62b41b4-cd20-11e6-9c97-9f295651dc37.png">
4 participants
