Redeferral fixes #1915
Closed
Redeferral fixes #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pleath
commented
Nov 4, 2016
pleath
commented
- Prevent redeferring during undeferral. 2. Clear inline caches on ScriptFunctionWithInlineCache after FunctionBody has been redeferred. 3. Fix asserts that appeared after Lei's deadlock fixes.
eligible for deferred parsing (e.g., not arrow functions, not functions-in-block). This is experimental behavior, off by default. Define an 'on' mode in which all eligible functions are redeferred on GC, as well as a 'stress' mode in which all candidates are redeferred on each stack probe. This change is built on a previous PR that refactors the FunctionBody hierarchy to make it easier to toggle between deferred and fully-compiled states.
…ic that was causing us not to redefer with default switches. 2. Fix a check on the entry point info's state that was preventing us from redeferring functions that have not been jitted.
…inline caches on ScriptFunctionWithInlineCache after FunctionBody has been redeferred. 3. Fix asserts that appeared after Lei's deadlock fixes.
Contributor
Author
|
Subsumed by #1585. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.