cache debugManager JIT addrs on new ScriptContext, instead of new ThreadContext #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarwal-sandeep
approved these changes
Oct 18, 2016
chakrabot
pushed a commit
that referenced
this pull request
Oct 18, 2016
…ontext, instead of new ThreadContext Merge pull request #1758 from MikeHolman:debugmanageroop In case primary ScriptContext is closed, threadContext->debugManager can be freed, and if new ScriptContext is later opened, a new debugManager is created. In this case, the address we initially cached on the JIT will be wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case primary ScriptContext is closed, threadContext->debugManager can be freed, and if new ScriptContext is later opened, a new debugManager is created. In this case, the address we initially cached on the JIT will be wrong.