fix crash when using jscript ETW provider #1698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ThomsonTan
reviewed
Oct 6, 2016
| uint GetFunctionNumber() const | ||
| { | ||
| return this->jitData.jitData->bodyData->funcNumber; | ||
| return this->functionBody->GetFunctionNumber(); |
Collaborator
There was a problem hiding this comment.
this->functionBody [](start = 15, length = 18)
What the difference between this->functionBody and this->jitData.jitData->bodyData? Also wondering why we could get AV in the latter case.
Contributor
Author
There was a problem hiding this comment.
this->jitData.jitData is not initialized until NativeCodeGenerator::CodeGen, whereas functionBody is passed as argument to the constructor of CodeGenWorkItem so is there from the beginning.
This area definitely got a bit messy with OOP JIT, and I'm planning on doing bigger cleanup of CodeGenWorkItem to address this sort of strangeness.
Collaborator
|
|
chakrabot
pushed a commit
that referenced
this pull request
Oct 6, 2016
Merge pull request #1698 from MikeHolman:etw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.