Skip to content

Reorder the ByteCodeUse and Cm/Br(Sr)?[GL][te] instructions in the unsigned compare peep #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Penguinwizzard merged 2 commits into from
Sep 26, 2016
Merged

Reorder the ByteCodeUse and Cm/Br(Sr)?[GL][te] instructions in the unsigned compare peep #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed813dc
Fix some tab issues to satisfy new, stricter CI tab requirements.
Penguinwizzard Sep 22, 2016
39b1603
Reorder the ByteCodeUse and Cm/Br(Sr)?[GL][te] instructions in the un…
Penguinwizzard Sep 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Backend/FlowGraph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3022,8 +3022,8 @@ bool FlowGraph::UnsignedCmpPeep(IR::Instr *cmpInstr)
//
// t1 = ShrU_A x, 0
// t2 = 10;
// ByteCodeUse t1
// BrUnGt x, t2, L
// ByteCodeUse t1
//
// Hopefully dead-store can get rid of the ShrU

Expand Down Expand Up @@ -3090,7 +3090,7 @@ bool FlowGraph::UnsignedCmpPeep(IR::Instr *cmpInstr)
IR::ByteCodeUsesInstr * bytecodeInstr = IR::ByteCodeUsesInstr::New(cmpInstr->m_func);
bytecodeInstr->SetByteCodeOffset(cmpInstr);
bytecodeInstr->byteCodeUpwardExposedUsed = Anew(cmpInstr->m_func->m_alloc, BVSparse<JitArenaAllocator>,cmpInstr->m_func->m_alloc);
cmpInstr->InsertBefore(bytecodeInstr);
cmpInstr->InsertAfter(bytecodeInstr);

if (cmpSrc1 != newSrc1)
{
Expand Down
8 changes: 4 additions & 4 deletions lib/Backend/Lower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10206,7 +10206,7 @@ Lowerer::LowerArgIn(IR::Instr *instrArgIn)
this->m_lowererMD.ChangeToAssign(instrArgIn);
}

JitAdelete(this->m_alloc, formalsBv);
JitAdelete(this->m_alloc, formalsBv);

return instrResume;
}
Expand Down Expand Up @@ -10248,8 +10248,8 @@ Lowerer::LoadGeneratorObject(IR::Instr * instrInsert)
instrInsert->m_func->SetArgOffset(generatorSym, LowererMD::GetFormalParamOffset() * MachPtr);
IR::SymOpnd * generatorSymOpnd = IR::SymOpnd::New(generatorSym, TyMachPtr, instrInsert->m_func);
IR::RegOpnd * generatorRegOpnd = IR::RegOpnd::New(TyMachPtr, instrInsert->m_func);
instrInsert->m_func->SetHasImplicitParamLoad();
return LowererMD::CreateAssign(generatorRegOpnd, generatorSymOpnd, instrInsert);
instrInsert->m_func->SetHasImplicitParamLoad();
return LowererMD::CreateAssign(generatorRegOpnd, generatorSymOpnd, instrInsert);
}

IR::Instr *
Expand Down Expand Up @@ -10904,7 +10904,7 @@ Lowerer::LoadCallInfo(IR::Instr * instrInsert)
{
// Generator function arguments and ArgumentsInfo are not on the stack. Instead they
// are accessed off the generator object (which is prm1).
IR::Instr *genLoadInstr = LoadGeneratorObject(instrInsert);
IR::Instr *genLoadInstr = LoadGeneratorObject(instrInsert);
IR::RegOpnd * generatorRegOpnd = genLoadInstr->GetDst()->AsRegOpnd();

IR::IndirOpnd * indirOpnd = IR::IndirOpnd::New(generatorRegOpnd, Js::JavascriptGenerator::GetCallInfoOffset(), TyMachPtr, func);
Expand Down