ModuleNamespace Support #1401
Merged
ModuleNamespace Support #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for module namespace. The basic syntax is export * as myNS from 'submodule.js' The namespace is a sealed object with all the exported properties from the currently module. The properties are not changable. They are also "reference property" in that it should look up the original property instead of caching the value of the property. There are three set of properties in the namespace object: . builtin Symbol properties, include Symbol.toStringTag & Symbol.iterator at this time. . local exports. As the local exports are allocated in the specific slot array. . nonlocal exports. We need to forward the call to other referencing module namespace object. Similarly, the enumerator needs to take care of the different kinds of properties. However, the iterator need to iterate through the property names in sorted order. We'll create the iterator for a sorted name list. CreateListIterator operation (7.4.8) is implemented as well. Add a set of unittests to cover the object behavior of namespace object.
lib/Runtime/Base/JnDirectFields.h
Outdated
| ENTRY(decodeURIComponent) | ||
| ENTRY2(default_, _u("default")) | ||
| ENTRY2(delete_, _u("delete")) // "delete" cannot be an identifier in C++ so using "delete_" instead | ||
| ENTRY2(star, _u("*")) |
Contributor
There was a problem hiding this comment.
Should we indicate this is a symbol (change name to "_star" or similar)? It seems unlikely, but a built-in API might come along with the name of star (String.prototype.star maybe). #Resolved
Contributor
| TypeIds_HostObject = 72, | ||
| TypeIds_ActivationObject = 73, | ||
| TypeIds_SpreadArgument = 74, | ||
| TypeIds_ModuleNamespace = 75, |
Contributor
There was a problem hiding this comment.
TypeIds_ModuleNamespace [](start = 4, length = 23)
Is this object a "TrueJavascriptObjectType" ? #ByDesign
Contributor
Author
There was a problem hiding this comment.
Contributor
|
Cool stuff! 👍 |
Contributor
Author
Contributor
Author
|
@dotnet-bot test Windows x86_test please |
chakrabot
pushed a commit
that referenced
this pull request
Aug 11, 2016
Merge pull request #1401 from Yongqu:modulens Add support for module namespace. The basic syntax is export * as myNS from 'submodule.js' The namespace is a sealed object with all the exported properties from the currently module. The properties are not changable. They are also "reference property" in that it should look up the original property instead of caching the value of the property. There are three set of properties in the namespace object: . builtin Symbol properties, include Symbol.toStringTag & Symbol.iterator at this time. . local exports. As the local exports are allocated in the specific slot array. . nonlocal exports. We need to forward the call to other referencing module namespace object. Similarly, the enumerator needs to take care of the different kinds of properties. However, the iterator need to iterate through the property names in sorted order. We'll create the iterator for a sorted name list. CreateListIterator operation (7.4.8) is implemented as well. Add a set of unittests to cover the object behavior of namespace object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for module namespace. The basic syntax is
export * as myNS from 'submodule.js'
The namespace is a sealed object with all the exported properties from the currently
module. The properties are not changable. They are also "reference property" in that
it should look up the original property instead of caching the value of the property.