xplat: add eh frame data to thunks #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pop_nonvol_reg rbp | ||
| NESTED_END _ZN2Js18JavascriptFunction20DeferredParsingThunkEPNS_16RecyclableObjectENS_8CallInfoEz, _TEXT | ||
|
|
||
| jmp rax |
Collaborator
There was a problem hiding this comment.
@jianchun this needs to be moved before NESTED_END. Same applies to the one below. After that, perhaps it should just work. I don't see anything else problematic here. Didn't check the codes but interesting clang/ld etc didn't bother linking this one on Ubuntu..
Author
There was a problem hiding this comment.
@obastemur Thanks for looking! Do you mean moving jmp rax? (Was troubled by this one. Would look fine if it were a call and ret before NESTED_END. But it is a jmp.)
Author
There was a problem hiding this comment.
Trying that, seems working fine after moved on Ubuntu
DeferredParsingThunk asm didn't have eh frame data. If an exception is thrown during its execution (calling JavascriptFunction::DeferredParse), process will crash because it cannot unwind the stack correctly. Changed to use asm macroes which adds cfi directives. Applied the same fix to DeferredDeserializeThunk.
Collaborator
|
|
Contributor
|
lgtm |
Author
|
@obastemur @digitalinfinity Thanks! |
chakrabot
pushed a commit
that referenced
this pull request
Jul 29, 2016
Merge pull request #1354 from jianchun:fixasm DeferredParsingThunk asm didn't have eh frame data. If an exception is thrown during its execution (calling JavascriptFunction::DeferredParse), process will crash because it cannot unwind the stack correctly. Changed to use asm macroes which adds cfi directives. Applied the same fix to DeferredDeserializeThunk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeferredParsingThunk asm didn't have eh frame data. If an exception is
thrown during its execution (calling JavascriptFunction::DeferredParse),
process will crash because it cannot unwind the stack correctly.
Changed to use asm macroes which adds cfi directives. Applied the same
fix to DeferredDeserializeThunk.