Skip to content

cross-platform: fix stack related issues on macOS #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chakrabot merged 1 commit into from
Jul 22, 2016
Merged

cross-platform: fix stack related issues on macOS #1306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bin/ch/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
set(ch_source_files
set(ch_source_files
ch.cpp
ChakraRtInterface.cpp
CodexAssert.cpp
Expand Down Expand Up @@ -67,6 +67,8 @@ if(STATIC_LIBRARY)
icucore
"-framework CoreFoundation"
"-framework Security"
# set stack size to 64Mb for stack tests
-Wl,-stack_size,0x04000000
)
endif() # Linux ?
else() # // !from shared library
Expand All @@ -78,7 +80,7 @@ else() # // !from shared library
endif()

if(CMAKE_SYSTEM_NAME STREQUAL Linux)
set(lib_target "${lib_target}"
set(lib_target "${lib_target}"
-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/ch.version
)
endif()
Expand Down
4 changes: 2 additions & 2 deletions test/Error/stack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ function DoSomething()

try
{
var count = 20000; // Keep this unrealistic number as we do not
// limit stack memory to a particular capacity
var count = 200000; // Keep this unrealistic number as we do (osx)
// and do not limit stack memory to a particular capacity

var a = {};
var b = a;
Expand Down