cross-platform: Make amd64 asm files compile on OSX #1131
Conversation
|
Hi @tadeuzagallo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
|
|
||
| #ifndef __APPLE__ | ||
| .type _ZN2Js18JavascriptFunction20DeferredParsingThunkEPNS_16RecyclableObjectENS_8CallInfoEz, @function | ||
| .type _ZN2Js18JavascriptFunction24DeferredDeserializeThunkEPNS_16RecyclableObjectENS_8CallInfoEz, @function | ||
| .type C_FUNC(_ZN2Js18JavascriptFunction20DeferredParsingThunkEPNS_16RecyclableObjectENS_8CallInfoEz), @function |
There was a problem hiding this comment.
C_FUNC is not needed here
There was a problem hiding this comment.
I know it's not currently necessary, but it relies on an assumption of how the compiler mangles the symbols, so I usually prefer to keep it for consistency. Of course I can remove it though.
There was a problem hiding this comment.
@tadeuzagallo pseudo-op .type is not supported by OSX target anyways.
|
@tadeuzagallo IMO these files need a bit more change to be OSX compatible or to be able to pass the linker. However, I'm okay with the changes overall. Please update the title from Thanks for the PR! |
tadeuzagallo
changed the title
|
LGTM. @tadeuzagallo Thanks for the PR again |
Merge pull request #1131 from tadeuzagallo:linux The assembly files fail to assemble due to unsupported `@plt` modifier and fail to link on OS X due to missing label prefix on function names.
Merge pull request #1134 from obastemur:osx_support Disclaimer: Currently, ChakraCore is not officially supported on OSX. This PR targets the individuals interested with experimenting ChakraCore on OSX. After seeing #1131, spent couple of hours to fix the compile, and link time issues on OSX target. Steps to compile : ``` brew install icu4c ./build.sh --debug -j:2 --icu=/usr/local/Cellar/icu4c/54.1/include/ ``` Status: CMAKE has an issue with shared bundles on OSX (a.k.a. so) and currently CH does not play well with dylib.
Disclaimer: Currently, ChakraCore is not officially supported on OSX. This PR targets the individuals interested with experimenting ChakraCore on OSX. After seeing chakra-core#1131, spent couple of hours to fix the compile, and link time issues on OSX target. Steps to compile : ``` brew install icu4c ./build.sh --debug -j:2 --icu=/usr/local/Cellar/icu4c/54.1/include/ ``` Status: CMAKE has an issue with OSX shared bundles and currently CH does not play well with dylib output.
The assembly files fail to assemble due to unsupported
@pltmodifier and fail to link on OS X due to missing label prefix on function names.