Addressing code review comments

chakra-core · May 15, 2017 · 6b1731f · 6b1731f
1 parent 1113bfe
commit 6b1731f
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/Runtime/Library/JavascriptExceptionMetadata.cpp b/lib/Runtime/Library/JavascriptExceptionMetadata.cpp
@@ -95,10 +95,10 @@ namespace Js {
 
         LPCUTF8 functionSource = sourceInfo->GetSource(_u("Jsrt::JsExperimentalGetAndClearExceptionWithMetadata"));
 
-        charcount_t startByteOffset;
-        charcount_t endByteOffset;
-        charcount_t startCharOffset;
-        charcount_t endCharOffset;
+        charcount_t startByteOffset = 0;
+        charcount_t endByteOffset = 0;
+        charcount_t startCharOffset = 0;
+        charcount_t endCharOffset = 0;
 
 
         startCharOffset = cache->GetCharacterOffsetForLine(line, &startByteOffset);
@@ -143,7 +143,7 @@ namespace Js {
                 }
                 else
                 {
-                    // This should not be possible
+                    AssertMsg(FALSE, "Line ending logic out of sync between Js::JavascriptExceptionMetadata and JsUtil::LineOffsetCache::GetCharacterOffsetForLine");
                     return false;
                 }
             }