Add tests for #5097

chakra-core · May 7, 2018 · 3d90e7e · 3d90e7e
1 parent 317632b
commit 3d90e7e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/lib/Runtime/Library/IntlEngineInterfaceExtensionObject.cpp b/lib/Runtime/Library/IntlEngineInterfaceExtensionObject.cpp
@@ -2192,10 +2192,10 @@ namespace Js
     {
     private:
         double num;
-        Field(const char16) *formatted;
+        Field(const char16 *) formatted;
         const charcount_t formattedLength;
-        Field(ScriptContext) *sc;
-        Field(UNumberFormatFields) *fields;
+        Field(ScriptContext *) sc;
+        Field(UNumberFormatFields *) fields;
 
         static const UNumberFormatFields UnsetField = static_cast<UNumberFormatFields>(0xFFFFFFFF);
 

diff --git a/test/Intl/Collator.js b/test/Intl/Collator.js
@@ -177,4 +177,16 @@ testRunner.runTests([
             pairs.forEach((pair) => test(pair[0], pair[1]));
         }
     },
+    {
+        name: "https://github.com/Microsoft/ChakraCore/issues/5097",
+        body() {
+            const cases = [0, 1, true, false, null, undefined, { toString() { return "hello!" }}, [1, 2, 3, 4], {}, new (class ToStringTag { get [Symbol.toStringTag]() { return "MyClass" } })];
+
+            const coll = new Intl.Collator();
+            cases.forEach((test) => {
+                assert.areEqual(0, ("" + test).localeCompare(test), `${test} did not compare equal to itself using String.prototype.localeCompare`);
+                assert.areEqual(0, coll.compare("" + test, test), `${test} did not compare equal to itself using Collator.prototype.compare`);
+            });
+        }
+    }
 ], { verbose: !WScript.Arguments.includes("summary") });