Fixed issue where initCheck : false was not working #22 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthyG
reviewed
Feb 23, 2021
src/index.js
Outdated
| @@ -141,6 +142,8 @@ export function form(fn, config = {}) { | |||
| config | |||
| ); | |||
|
|
|||
| storeValue.update(value => ({ ...value, initCheck: config.initCheck })); | |||
There was a problem hiding this comment.
Am I missing something or could this not just be added to `storeValue` right away 🤔 (so move config above const storeValue = ... (L128)
There was a problem hiding this comment.
Can be done @AnthyG , I did not want to move the structure much, that's why I haven't moved it.
| } else { | ||
| node.classList.remove(valid); | ||
| node.classList.add(invalid); | ||
| if ((!context.initCheck && field.dirty) || context.initCheck) { |
|
@AnthyG Should I make your suggested changes and push again? |
|
Yeah, if there hasn't been any specific reason why you used It keeps the code cleaner in the long run ;) |
|
@AnthyG and @chainlist I have updated the code fixing the issue(#22) for |
|
@DhyeyMoliya thanks for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue : #22
Description : Used
field.dirtyandconfig.initCheckto control css classadd/remove