Closed
Conversation
Signed-off-by: Josh Wolf <josh@wolfs.io>
This was referenced Jun 20, 2023
Merged
Contributor
Author
|
closing this in favor of #1050 |
developer-guy
pushed a commit
to Dentrax/images
that referenced
this pull request
Feb 12, 2024
Signed-off-by: Jason Hall <jason@chainguard.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEPENDS ON: wolfi-dev/os#2970
Fixes:
Related:
Pre-review Checklist
Quality Requirements for Images PRs
The items in this checklist should all be checked in the PR with exceptions clearly documented.
The general idea is that to the extent possible, the image should be a drop-in replacement to its public counterpart.
For new image PRs only
If you have an apko.yaml file in this PR you need to follow this checklist, otherwise feel free to remove.
Include tests, sufficient enough that you would trust this image running in production.
Perform manual tests as needed and document your testing results
The version included is the latest GA version of the software
The latest tag points to the newest stable version
There is a dev tag available that includes a shell and apk tools (by depending on 'wolfi-base')
The image runs as
nonrootand GID/UID are set to 65532 or upstream defaultThe image contains the ca-certs bundle if needed
ENTRYPOINT
CMD:
–helpAdd annotations e.g:
docker kill $(docker run -d --rm cgr.dev/chainguard/nginx)Documentation Requirements