Skip to content

Conversation

@Dentrax
Copy link
Contributor

@Dentrax Dentrax commented Jun 6, 2023

Fixes:

Related:

Dockerfile: https://github.com/newrelic/infrastructure-bundle/blob/master/Dockerfile

Helm: https://github.com/newrelic/nri-kubernetes/tree/main/charts/newrelic-infrastructure

192MB -> 149.2MB

   ├── 0 critical, 4 high, 5 medium, 1 low, 0 negligible
   └── 2 fixed
NAME                        INSTALLED                           FIXED-IN                           TYPE       VULNERABILITY        SEVERITY
golang.org/x/sys            v0.0.0-20210403161142-5e06dd20ab57  0.0.0-20220412211240-33da011f77ad  go-module  GHSA-p782-xgp4-8hr8  Medium
google.golang.org/protobuf  v1.29.0                             1.29.1                             go-module  GHSA-hw7c-3rfg-p46j  Low

This vulnerabilities because of we download all the compiled binaries from the upstream. See the discussion. Other packages does not contain any vulnerabilities. I'll file a tracking issue to resolve this.

Pre-review Checklist

  • IMPORTANT: 'image-request' tag has been applied if this PR is adding any images, including new versions or variants

Quality Requirements for Images PRs

The items in this checklist should all be checked in the PR with exceptions clearly documented.
The general idea is that to the extent possible, the image should be a drop-in replacement to its public counterpart.

  • Image is a smaller size than its common public counterpart, or if not, the reason why should be explained
  • Image should be scanned for CVEs and should return 0 or near-0 results. Exceptions should be explained.
  • The software in the image should be able to be installed and work as expected
    • The image should start in a cluster
    • The application should be accessible to the user/cluster/etc. as expected
  • If there is an open source helm chart provided, the image should be able to be used with the chart. If needed, please add a -compat package to close any gaps with the public helm chart.
  • build for x86_64 and aarch64 if possible, document exceptions

For new image PRs only

If you have an apko.yaml file in this PR you need to follow this checklist, otherwise feel free to remove.

  • Include tests, sufficient enough that you would trust this image running in production.

  • Perform manual tests as needed and document your testing results

    • For builder images (go, python, etc), build a sample app successfully
    • For services images (rabbit, databases, webservers) test basic functionality, upstream install/getting started, port availability, admin access. Document differences from public image.
    • Applications intended for use with a specific cloud provider must be tested on that cloud provider.
  • The version included is the latest GA version of the software

  • The latest tag points to the newest stable version

  • There is a dev tag available that includes a shell and apk tools (by depending on 'wolfi-base')

  • The image runs as nonroot and GID/UID are set to 65532 or upstream default

    • Alternatively the username and GID/UID may be a commonly used one from the ecosystem e.g: postgres
  • The image contains the ca-certs bundle if needed

  • ENTRYPOINT

    • For applications/servers/utilities call main program with no arguments e.g. [redis-server]
    • For base images leave empty
    • For dev variants set to entrypoint script that falls back to system
  • CMD:

    • For server applications give arguments to start in daemon mode (may be empty)
    • For utilities/tooling bring up help e.g. –help
    • For base images with a shell, call it e.g. [/bin/sh]
  • Add annotations e.g:

annotations:
  "org.opencontainers.image.authors": "Chainguard Team https://www.chainguard.dev/"
  "org.opencontainers.image.url": https://edu.chainguard.dev/chainguard/chainguard-images/reference/busybox/ # use the academy site here
  "org.opencontainers.image.source": https://github.com/chainguard-images/images/tree/main/images/bazel # use github here
  • Check if environment variables are needed e.g. to set data locations
  • Ensure the image responds to SIGTERM
    • docker kill $(docker run -d --rm cgr.dev/chainguard/nginx)
  • Error logs write to stderr and normal logs to stdout. DO NOT write to file.

Documentation Requirements

  • Provide a README file, follow the README template to include variants, tags, and usage examples
  • Document your testing and results in the PR
  • Document any exceptions to the testing and config requirements outlined in this template
  • Document where and how the image deviates from popular alternatives (ports, packages, user, entrypoint, versions, etc). Explain why there's a difference and if the user needs to do anything differently when using the image

@Dentrax Dentrax requested a review from a team as a code owner June 6, 2023 21:14
@Dentrax Dentrax requested a review from rawlingsj June 6, 2023 21:14
Signed-off-by: Furkan Türkal <[email protected]>
Co-authored-by: Batuhan <[email protected]>
@Dentrax Dentrax force-pushed the newrelic-infrastructure-bundle branch from ea0d6f4 to fbbbb44 Compare June 6, 2023 21:15
@imjasonh imjasonh merged commit fc53331 into chainguard-images:main Jun 6, 2023
developer-guy pushed a commit to Dentrax/images that referenced this pull request Feb 12, 2024
…guard-images#827)

* kubernetes-csi-external-attacher-fips-4.4/4.4.1 package update

Signed-off-by: wolfi-bot <[email protected]>

* Update kubernetes-csi-external-attacher-fips-4.4.yaml

---------

Signed-off-by: wolfi-bot <[email protected]>
Co-authored-by: wolfi-bot <[email protected]>
Co-authored-by: Nghia Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants