fpr: lots of false positive reduction #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattlorimor
commented
Jan 23, 2025
Comment on lines
-67
to
+68
| AND file.path NOT LIKE '/var/tmp/IN_PROGRESS_sysdiagnose_%.tmp/mddiagnose.mdsdiagnostic/diagnostic.log' | ||
| -- These mddiagnose ones could maybe be squashed to '/var/tmp/sysdiagnose_%/mddiagnose.mdsdiagnostic/%.log' | ||
| AND file.path NOT LIKE '/var/tmp/sysdiagnose_%/mddiagnose.mdsdiagnostic/corespotlight%.log' | ||
| AND file.path NOT LIKE '/var/tmp/sysdiagnose_%/mddiagnose.mdsdiagnostic/diagnostic.log' | ||
| AND file.path NOT LIKE '/var/tmp/sysdiagnose_%/mddiagnose.mdsdiagnostic/general.log' | ||
| AND file.path NOT LIKE '/var/tmp/sysdiagnose_%/mddiagnose.mdsdiagnostic/importer_diag.log' | ||
| AND file.path NOT LIKE '/var/tmp/IN_PROGRESS_sysdiagnose_%.tmp/mddiagnose.mdsdiagnostic/%.log' | ||
| AND file.path NOT LIKE '/var/tmp/sysdiagnose_%/mddiagnose.mdsdiagnostic/%.log' |
There was a problem hiding this comment.
Compressed this
mattlorimor
commented
Jan 23, 2025
Comment on lines
+238
to
+242
| AND NOT ( | ||
| signature.authority = 'Developer ID Application: Tailscale Inc. (W5364U7YZB)' | ||
| AND lp.port > 5000 | ||
| AND lp.protocol = 6 | ||
| ) |
There was a problem hiding this comment.
Ripped out the too-specific tailscale checks up top and squashed it here.
mattlorimor
commented
Jan 23, 2025
Comment on lines
+90
to
+96
| AND NOT ( | ||
| ( | ||
| cgroup_path LIKE '/user.slice/user-1000.slice/[email protected]/app.slice/app-org.gnome.Terminal.slice/vte-spawn-%.scope' | ||
| OR cgroup_path LIKE '/user.slice/user-1000.slice/[email protected]/user.slice/docker-%.scope' | ||
| ) | ||
| AND path LIKE '/usr/share/nvm/versions/node/v%/bin/node' | ||
| ) |
There was a problem hiding this comment.
Does this do what I think it does: not fire if cgroup_path is either of those AND when path matches?
There was a problem hiding this comment.
That makes sense to me. If either of the two items are true and the third item is true, then the alert won't fire.
egibs
approved these changes
Jan 23, 2025
tstromberg
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.