fix(bump): Only update first git-checkout node with expected-commit #1959
Conversation
- Previously, all git-checkout nodes in a config were updated with the same commit SHA. - This caused incorrect updates when multiple git-checkout steps exist, each referring to different repositories or commits. - Now, only the first git-checkout node is updated to prevent partial or broken updates. - Reduces incorrect automated updates and the need for manual intervention. Signed-off-by: Debasish Biswas <[email protected]>
|
This change helps prevent the automation from unnecessarily updating expected-commit SHAs. In some cases — for example, this commit — we’ve seen that automation updates the wrong expected-commit. |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug where all git-checkout nodes were updated with the same commit SHA. The changes ensure that only the first git-checkout node is updated, preventing incorrect or partial updates.
- Updated the logic to process only the first git-checkout node
- Removed the loop that iterated over all git-checkout nodes
Signed-off-by: Debasish Biswas <[email protected]>
| Filter(yit.WithMapValue("git-checkout")) | ||
|
|
||
| for gitCheckoutNode, ok := it(); ok; gitCheckoutNode, ok = it() { | ||
| // Only run updateGitCheckout once for the first git-checkout node |
There was a problem hiding this comment.
This sounds like a limitation. I'd consider instead to request support for checking updates for any of the git-checkouts.
|
Closing as we already have: #2008 |
2 participants
Melange Pull Request Template
Functional Changes
Notes:
SCA Changes
Notes:
Linter
Notes: