sonarcube false positives: handle renamed rule #789
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Example usage where it was flagged without detecting that it was an exception: wolfi-dev/os#41189 |
In commit 3147dd1 ("Update third-party rules as of 2025-01-26 (chainguard-dev#780)"), the the YARAForge rule for detecting Eziriz .NET Reactor obfuscated DLLs was renamed from `COD3NYM_SUSP_OBF_NET_Reactor_Indicators_Jan24` to `COD3NYM_Reactor_Indicators`. However, this rule has a false positive exception because it seems Sonarqube uses this obfuscator on its CSharp and VBWeb plugin DLLs, but the exception rule was not updated at the same time the rule was renamed. Fix that. [Verified that none of the other rule names in the third-party rules update that changed are referenced in the false_positives directory.] v2: perform `yr fmt` on the sonarqube.yara file to make the CI happy Signed-off-by: Steve Beattie <steve.beattie@chainguard.dev>
stevebeattie
force-pushed
the
sonarcube_exception
branch
from
1b9d146 to
bba6cac
Compare
Member
Author
|
Fixed in #788, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 3147dd1 ("Update third-party rules as of 2025-01-26 (#780)"), the the YARAForge rule for detecting Eziriz .NET Reactor obfuscated DLLs was renamed from
COD3NYM_SUSP_OBF_NET_Reactor_Indicators_Jan24toCOD3NYM_Reactor_Indicators.However, this rule has a false positive exception because it seems Sonarqube uses this obfuscator on its CSharp and VBWeb plugin DLLs, but the exception rule was not updated at the same time the rule was renamed. Fix that.
[Verified that none of the other rule names in the third-party rules update that changed are referenced in the false_positives directory.]