Extract .jar and .zip files concurrently, use buffer for all io.Copy operations #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
egibs
changed the title
Signed-off-by: egibs <[email protected]>
Signed-off-by: egibs <[email protected]>
stevebeattie
approved these changes
Jan 27, 2025
Member
stevebeattie
left a comment
stevebeattie
left a comment
There was a problem hiding this comment.
LGTM, and saw a slight performance increase in limited testing. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can speed up the extraction of large packages like Spark and Trino by using concurrency since both contain many
.jarfiles. Both.jarand.ziparchives can be extracted in parallel rather than sequentially which is fortuitous in this case since these packages, when fully extracted, amount to somewhere in the neighborhood of ~1e5 files.Additionally, we can improve overall memory usage by using a buffer pool and
io.CopyBufferacross all extraction methods.Finally, I fixed
.xzextractions not using a limit reader which slipped through previous optimizations.