Address false positives seen with argocd, grafana, jupyterhub, and reflex #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
force-pushed
the
20241001-false-positive-fixes
branch
from
5dac973 to
a3d417f
Compare
Signed-off-by: Evan Gibler <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Member
Author
|
The changes in |
tstromberg
suggested changes
Oct 1, 2024
| $a_const = "const " | ||
| $a_function = "function(" | ||
| $a_return = "{return" | ||
Member
Author
There was a problem hiding this comment.
If we move these to high, I can remove the exclusions. That would be a lot cleaner.
There was a problem hiding this comment.
Works for me. In my mind, "CRITICAL" rules should never be broad enough for false positives to easily happen.
rules/combo/degrader/edr_killer.yara
Outdated
| $kill_gmh = "GetModuleHandle" | ||
| $kill_tp = "TerminateProcess" | ||
| $not_printdeps_exe = {55 73 61 67 65 3A 0A 20 20 50 72 69 6E 74 44 65 70 73 20 46 49 4C 45 2E 2E 2E 00 00 00 00 00 56 65 72 73 69 6F 6E 3A 20 72 00 00 25 70 00 00 65 45 00 00 70 50} |
rules/combo/stealer/browser.yara
Outdated
| $not_ff_js = "Firefox can even throw an error" | ||
| $not_generated_comment = "// This file is generated" | ||
| $not_generated_file = "/utils/generate_types/index.js" | ||
| $not_microsoft = "Copyright (c) Microsoft Corporation." |
rules/combo/stealer/crypto.yara
Outdated
| $not_grafana = "self.webpackChunkgrafana=self.webpackChunkgrafana" | ||
| condition: | ||
| filesize < 50KB and $url and $POST and any of ($pk*) | ||
| filesize < 50KB and $url and $POST and any of ($pk*) and none of ($not_*) |
| $not_openjs = "Copyright OpenJS Foundation and other contributors <https://openjsf.org/>" | ||
| condition: | ||
| filesize < 256KB and #const > 32 and #function > 48 and #return > 64 | ||
| filesize < 256KB and #const > 32 and #function > 48 and #return > 64 and none of ($not_*) |
rules/obfuscation/js/parseInt.yara
Outdated
| $not_grafana = "self.webpackChunkgrafana=self.webpackChunkgrafana" | ||
| condition: | ||
| filesize < 256KB and #const > 16 and #function > 32 and #parseInt > 8 and #return > 32 | ||
| filesize < 256KB and #const > 16 and #function > 32 and #parseInt > 8 and #return > 32 and none of ($not_*) |
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
changed the title
tstromberg
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the [critical] false positives seen in these PRs:
The difficult exclusion was with the
PrintDeps.exefile, so I opted to exclude this string:Depends on chainguard-dev/malcontent-samples#8