Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Variable.data with Variable.array (again) #434

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Replace Variable.data with Variable.array (again) #434

merged 1 commit into from
Apr 4, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Apr 4, 2019

This PR resolves #335 (again).

@muupan muupan mentioned this pull request Apr 4, 2019
Merged
1 task
toslunar
toslunar reviewed Apr 4, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan muupan merged commit db8fa5c into chainer:master Apr 4, 2019
@muupan muupan deleted the use-array-instead-of-data2 branch April 4, 2019 09:30
@muupan muupan added this to the v0.7 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Use Variable.array instead of Variable.data
2 participants
@muupan @toslunar