Support gym==0.10.8 #324
Merged
Support gym==0.10.8 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove calls of gym.undo_logger_setup - remove chainerrl/spaces.py - import gym.spaces explicitly - import gym.wrappers explicitly
since jupyter-console has been updated to use new prompt-toolkit
|
CI was broken by the update of jupyter-console but it's also fixed by this PR. |
|
I confirmed that all the tests passed. |
toslunar
requested changes
Oct 9, 2018
chainerrl/envs/abc.py
Outdated
| @@ -9,7 +9,7 @@ | |||
| import numpy as np | |||
|
|
|||
| from chainerrl import env | |||
| from chainerrl import spaces | |||
| from gym import spaces | |||
There was a problem hiding this comment.
Could you fix the grouping of the imports?
chainerrl/envs/ale.py
Outdated
| @@ -13,7 +13,7 @@ | |||
| import numpy as np | |||
|
|
|||
| from chainerrl import env | |||
| from chainerrl import spaces | |||
| from gym import spaces | |||
There was a problem hiding this comment.
Could you fix the grouping of the imports?
|
I fixed the grouping of imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes following changes to support gym==0.10.8.
Support of gym older than 0.9.7 is dropped.
Resolves #323, #325.