Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check-error #1528

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Update check-error #1528

merged 1 commit into from
Jul 26, 2023

Conversation

koddsson
Copy link
Member

Since it's now an ES Module! :)

@koddsson koddsson requested a review from a team as a code owner July 21, 2023 20:49
@voxpelli
Copy link

@koddsson I see a new release for check-error on npm, but nothing in https://github.com/chaijs/check-error – no new tag or commits that refers to 2.0.0

As for chai itself, you need to alter how its loaded here:

exports.checkError = require('check-error');

require() can't load ESM-modules, you have to use (await import()).default instead.

Copy link

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment

@koddsson
Copy link
Member Author

As for chai itself, you need to alter how its loaded here:

I don't know what branch this file is in, but I'm targetting the 5.x.x branch, which doesn't have the require function call.

@voxpelli
Copy link

I don't know what branch this file is in, but I'm targetting the 5.x.x branch, which doesn't have the require function call.

Right, I missed that part as it wasn't mentioned in the PR itself and neither any link to any milestone or such :)

@koddsson
Copy link
Member Author

@keithamus; I don't have merge rights, so I can't land this myself.

It also might be good to remove node12 and node14 as required builds in the repo settings, since they are never going to be reported.

@koddsson koddsson merged commit c6481e0 into chaijs:5.x.x Jul 26, 2023
3 checks passed
@koddsson koddsson deleted the update-check-error branch July 26, 2023 07:21
renovate bot referenced this pull request in runtime-env/import-meta-env Jul 7, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [chai](http://chaijs.com) ([source](https://github.com/chaijs/chai))
| [`4.4.1` ->
`5.1.1`](https://renovatebot.com/diffs/npm/chai/4.4.1/5.1.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/chai/4.4.1/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/chai/4.4.1/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>chaijs/chai (chai)</summary>

### [`v5.1.1`](https://github.com/chaijs/chai/releases/tag/v5.1.1)

[Compare
Source](https://github.com/chaijs/chai/compare/v5.1.0...v5.1.1)

#### What's Changed

- Set up ESLint for JSDoc comments by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1605](https://github.com/chaijs/chai/pull/1605)
- build(deps-dev): bump ip from 1.1.8 to 1.1.9 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/chaijs/chai/pull/1608](https://github.com/chaijs/chai/pull/1608)
- Correct Mocha import instructions by
[@&#8203;MattiSG](https://github.com/MattiSG) in
[https://github.com/chaijs/chai/pull/1611](https://github.com/chaijs/chai/pull/1611)
- fix: support some virtual contexts in `toThrow` by
[@&#8203;43081j](https://github.com/43081j) in
[https://github.com/chaijs/chai/pull/1609](https://github.com/chaijs/chai/pull/1609)

#### New Contributors

- [@&#8203;MattiSG](https://github.com/MattiSG) made their first
contribution in
[https://github.com/chaijs/chai/pull/1611](https://github.com/chaijs/chai/pull/1611)

**Full Changelog**:
chaijs/chai@v5.1.0...v5.1.1

### [`v5.1.0`](https://github.com/chaijs/chai/releases/tag/v5.1.0)

[Compare
Source](https://github.com/chaijs/chai/compare/v5.0.3...v5.1.0)

#### What's Changed

- Remove useless guards and add parentheses to constuctors by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1593](https://github.com/chaijs/chai/pull/1593)
- Cleanup jsdoc comments by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1596](https://github.com/chaijs/chai/pull/1596)
- Convert comments in "legal comments" format to jsdoc or normal
comments by [@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1598](https://github.com/chaijs/chai/pull/1598)
- Implement `iterable` assertion by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1592](https://github.com/chaijs/chai/pull/1592)
- Assert interface fix by
[@&#8203;developer-bandi](https://github.com/developer-bandi) in
[https://github.com/chaijs/chai/pull/1601](https://github.com/chaijs/chai/pull/1601)
- Set support in same members by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1583](https://github.com/chaijs/chai/pull/1583)
- Fix publish script by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1602](https://github.com/chaijs/chai/pull/1602)

#### New Contributors

- [@&#8203;developer-bandi](https://github.com/developer-bandi) made
their first contribution in
[https://github.com/chaijs/chai/pull/1601](https://github.com/chaijs/chai/pull/1601)

**Full Changelog**:
chaijs/chai@v5.0.3...v5.1.0

### [`v5.0.3`](https://github.com/chaijs/chai/releases/tag/v5.0.3)

[Compare
Source](https://github.com/chaijs/chai/compare/v5.0.2...v5.0.3)

Fix bad v5.0.2 publish.

**Full Changelog**:
chaijs/chai@v5.0.2...v5.0.3

### [`v5.0.2`](https://github.com/chaijs/chai/releases/tag/v5.0.2)

[Compare
Source](https://github.com/chaijs/chai/compare/v5.0.0...v5.0.2)

#### What's Changed

- build(deps): bump nanoid and mocha by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/chaijs/chai/pull/1558](https://github.com/chaijs/chai/pull/1558)
- remove `bump-cli` by [@&#8203;koddsson](https://github.com/koddsson)
in
[https://github.com/chaijs/chai/pull/1559](https://github.com/chaijs/chai/pull/1559)
- Update developer dependencies by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1560](https://github.com/chaijs/chai/pull/1560)
- fix: removes `??` for node compat (5.x) by
[@&#8203;43081j](https://github.com/43081j) in
[https://github.com/chaijs/chai/pull/1576](https://github.com/chaijs/chai/pull/1576)
- Update `loupe` to latest version by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1579](https://github.com/chaijs/chai/pull/1579)
- Re-enable some webkit tests by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1580](https://github.com/chaijs/chai/pull/1580)
- Remove a bunch of if statements in test/should.js by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1581](https://github.com/chaijs/chai/pull/1581)
- Remove a bunch of unused files by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1582](https://github.com/chaijs/chai/pull/1582)
- Fix 1564 by [@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1566](https://github.com/chaijs/chai/pull/1566)

**Full Changelog**:
chaijs/chai@v5.0.1...v5.0.2

### [`v5.0.0`](https://github.com/chaijs/chai/releases/tag/v5.0.0)

[Compare
Source](https://github.com/chaijs/chai/compare/v4.4.1...v5.0.0)

#### BREAKING CHANGES

- Chai now only supports EcmaScript Modules (ESM). This means your tests
will need to either have `import {...} from 'chai'` or `import('chai')`.
`require('chai')` will cause failures in nodejs. If you're using ESM and
seeing failures, it may be due to a bundler or transpiler which is
incorrectly converting import statements into require calls.
-   Dropped support for Internet Explorer.
-   Dropped support for NodeJS < 18.
- Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome
100, Edge 100. Support for browsers prior to these versions is "best
effort" (bug reports on older browsers will be assessed individually and
may be marked as wontfix).

#### What's Changed

- feat: use chaijs/loupe for inspection by
[@&#8203;pcorpet](https://github.com/pcorpet) in
[https://github.com/chaijs/chai/pull/1401](https://github.com/chaijs/chai/pull/1401)
- docs: fix URL in README by [@&#8203;Izzur](https://github.com/Izzur)
in
[https://github.com/chaijs/chai/pull/1413](https://github.com/chaijs/chai/pull/1413)
- Remove `get-func-name` dependency by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1416](https://github.com/chaijs/chai/pull/1416)
- Convert Makefile script to npm scripts by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1424](https://github.com/chaijs/chai/pull/1424)
- Clean up README badges by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1422](https://github.com/chaijs/chai/pull/1422)
- fix: package.json - deprecation warning on exports field by
[@&#8203;stevenjoezhang](https://github.com/stevenjoezhang) in
[https://github.com/chaijs/chai/pull/1400](https://github.com/chaijs/chai/pull/1400)
- fix: deep-eql bump package to support symbols by
[@&#8203;snewcomer](https://github.com/snewcomer) in
[https://github.com/chaijs/chai/pull/1458](https://github.com/chaijs/chai/pull/1458)
- ES module conversion PoC by
[@&#8203;43081j](https://github.com/43081j) in
[https://github.com/chaijs/chai/pull/1498](https://github.com/chaijs/chai/pull/1498)
- chore: drop commonjs support by
[@&#8203;43081j](https://github.com/43081j) in
[https://github.com/chaijs/chai/pull/1503](https://github.com/chaijs/chai/pull/1503)
- Update pathval by [@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1527](https://github.com/chaijs/chai/pull/1527)
- Update check-error by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1528](https://github.com/chaijs/chai/pull/1528)
- update `deep-eql` to latest version by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1542](https://github.com/chaijs/chai/pull/1542)
- Inline `type-detect` as a simple function by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1544](https://github.com/chaijs/chai/pull/1544)
- Update loupe by [@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1545](https://github.com/chaijs/chai/pull/1545)
- Typo 'Test an object' not 'Test and object' by
[@&#8203;mavaddat](https://github.com/mavaddat) in
[https://github.com/chaijs/chai/pull/1460](https://github.com/chaijs/chai/pull/1460)
- Update `assertion-error` to it's latest major version! by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1543](https://github.com/chaijs/chai/pull/1543)
- Replacing Karma with Web Test Runner by
[@&#8203;koddsson](https://github.com/koddsson) in
[https://github.com/chaijs/chai/pull/1546](https://github.com/chaijs/chai/pull/1546)

#### New Contributors

- [@&#8203;Izzur](https://github.com/Izzur) made their first
contribution in
[https://github.com/chaijs/chai/pull/1413](https://github.com/chaijs/chai/pull/1413)
- [@&#8203;stevenjoezhang](https://github.com/stevenjoezhang) made
their first contribution in
[https://github.com/chaijs/chai/pull/1400](https://github.com/chaijs/chai/pull/1400)
- [@&#8203;43081j](https://github.com/43081j) made their first
contribution in
[https://github.com/chaijs/chai/pull/1498](https://github.com/chaijs/chai/pull/1498)

**Full Changelog**:
chaijs/chai@4.3.1...v5.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/runtime-env/import-meta-env).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants