feat: use chaijs/loupe for inspection #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @pcorpet! I’ll merge this and we can look to cut a pre-release for testing in the wild. |
thetutlage
reviewed
Jan 27, 2022
| }, "expected { tea: \'chai\' } to deeply equal { tea: \'black\' }"); | ||
| }, "expected {} to deeply equal {}"); |
There was a problem hiding this comment.
Wasn't the old message more descriptive?
keithamus
added a commit
that referenced
this pull request
Feb 7, 2023
* Fixed a regression that caused SyntaxErrors on IE 11 The changes made in #1334 incorrectly used an arrow function and as this isn't supported on IE 11 it causes a SyntaxError to be thrown when loading chai. * [email protected] * export chai.Assertion (#1378) * [email protected] * fix: support inspecting bigints (#1321) (#1383) * 4.3.4 * feat: use chaijs/loupe for inspection (#1401) (#1407) Fix #1228 * fix: package.json - deprecation warning on exports field (#1400) * fix package.json exports * build(deps-dev): bump codecov from 3.1.0 to 3.7.1 (#1446) Bumps [codecov](https://github.com/codecov/codecov-node) from 3.1.0 to 3.7.1. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Changelog](https://github.com/codecov/codecov-node/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-node@v3.1.0...v3.7.1) --- updated-dependencies: - dependency-name: codecov dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build chaijs * 4.3.5 * fix: use loupe@^2.3.1 * build chaijs * 4.3.6 * fix: deep-eql bump package to support symbols comparison (#1483) * 4.3.7 * build * chore: 4.x.x: Fix link to commit logs on GitHub (#1487) * 4.x.x: Fix link to commit logs on GitHub As there is no `master` branch, the link returned a 404. * Update History.md Co-authored-by: Andre Meyering <[email protected]> Co-authored-by: Keith Cirkel <[email protected]> * build(deps): bump socket.io-parser from 4.0.4 to 4.0.5 (#1488) Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io-parser@4.0.4...4.0.5) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test: fix typo in test.js (#1459) * docs: specify return type of objDisplay (#1490) previously it was incorrectly labeled as `objDisplay(obj: object): void` in `@types/chai`. * feat: rework into ES modules This moves all of the sources to be ES modules rather than CommonJS. In order to produce the entrypoints, we use esbuild as a bundler (and as a transpiler in a way). Due to the fact that some dependencies are written in CommonJS, we actually use esbuild to create _two_ bundles: a CommonJS bundle, and an ES module bundle. Otherwise, someone importing the raw source would inevitably end up trying to import a CommonJS module somewhere down the tree, which would not work in browsers natively. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Lee Newson <[email protected]> Co-authored-by: Keith Cirkel <[email protected]> Co-authored-by: rbruckheimer <[email protected]> Co-authored-by: Mike Frysinger <[email protected]> Co-authored-by: Pascal Corpet <[email protected]> Co-authored-by: Mimi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Scott Newcomer <[email protected]> Co-authored-by: Andre Meyering <[email protected]> Co-authored-by: Mavaddat Javid <[email protected]> Co-authored-by: scarf <[email protected]> Co-authored-by: James Garbutt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1228
Backport of #1401 in branch 4.x.x