Fixed a regression that caused SyntaxErrors on IE 11#1380
Closed
lnewson wants to merge 9 commits intochaijs:4.x.xfrom
lnewson:gh-1379
Closed
Fixed a regression that caused SyntaxErrors on IE 11#1380lnewson wants to merge 9 commits intochaijs:4.x.xfrom lnewson:gh-1379
lnewson wants to merge 9 commits intochaijs:4.x.xfrom
lnewson:gh-1379
Conversation
BREAKING CHANGE: This package no longer supports Node.js 4 through 12
The changes made in #1334 incorrectly used an arrow function and as this isn't supported on IE 11 it causes a SyntaxError to be thrown when loading chai.
keithamus
approved these changes
Mar 3, 2021
Member
|
Merged in 4.x.x branch |
Contributor
Author
|
Ahh, sorry I missed that 4.x had moved off to a side branch. Thanks for getting that fixed 👍 |
This was referenced Mar 5, 2021
This was referenced Jun 6, 2021
This was referenced Jun 14, 2021
1 task
This was referenced Jul 5, 2021
This was referenced Jul 19, 2021
This was referenced Jul 27, 2021
This was referenced Aug 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes made in #1334 used an arrow function and as this isn't supported on IE 11 it causes a SyntaxError to be thrown when loading chai. This just corrects that to use the older function syntax instead so it'll still be able to run on IE 11.
Fixes #1379