Skip to content

Add -S command line option to use a releasestream image#4

Merged
cgwalters merged 1 commit intocgwalters:masterfrom
rphillips:add_latest_release_image
Sep 27, 2020
Merged

Add -S command line option to use a releasestream image#4
cgwalters merged 1 commit intocgwalters:masterfrom
rphillips:add_latest_release_image

Conversation

@rphillips
Copy link
Contributor

@rphillips rphillips commented Feb 14, 2020

Uses a release stream name to fetch the latest release image.

xokdinst launch -S 4.4.0-0.nightly -p libvirt test1

Also adds TF_VAR injection into the installer environment for overrides.

Copy link
Owner

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great, mind rebasing?

This lets us pull the most recent build from a stream
conveniently.
@cgwalters cgwalters force-pushed the add_latest_release_image branch from 249674a to e7d60d1 Compare September 27, 2020 21:31
@cgwalters
Copy link
Owner

Nevermind I rebased 🏄 this and also did some other cleanups - in particular:

  • Only fetch the stream once rather than each time we launch the installer
  • Return Result<> rather than calling unwrap() when we're doing things like the HTTP request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants