Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile error #34

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix compile error #34

merged 1 commit into from
Oct 11, 2024

Conversation

cgpadwick
Copy link
Owner

NetworkTablesConfig.h had a couple of problems:

  • no #ifndef directive at the top of the file
  • wrong type defined for strings, NetworkTables classes were expecting const char* instead of std::string. I could have fixed this by adding a .c_str() to each instance were they were used but this was faster
  • needed inline added in the definition to avoid multiple declaration linker errors

@cgpadwick cgpadwick requested a review from maxspier October 11, 2024 03:01
maxspier
maxspier approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@maxspier maxspier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM!

@maxspier maxspier merged commit ddbd47d into main Oct 11, 2024
@maxspier maxspier deleted the chris.padwick/nt_compile_error branch October 11, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxspier maxspier maxspier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgpadwick @maxspier @jungleman007