-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiarch compatibility #206
base: master
Are you sure you want to change the base?
Conversation
Gbp-Pq: Name Use-GNUInstallDirs.patch
Gbp-Pq: Name Fix-CMake-packaging-setup.patch
Thanks for this PR. I will discuss this with the other maintainers. |
It may be that the differing build-types are actually another issue (cginternals/cmake-init#36). |
Indeed.
CMake should create both a |
This commit seems to work pretty good, is there a reason why it was never merged? |
@scheibel The changes in this PR still seems to work BTW. |
At the moment,
glbinding
is not compatible with multiarch systems. This PR modifies the installation path variables and target settings to achieve this.The first commit uses GNUInstallDirs to provide the multiarch install paths. This is a pretty standard solution and keeps the old behavior in case the system is not multiarch.
The second commit addresses CMake detection on multiarch (and non-multiarch) systems. The old settings were not flexible enough and not exactly compliant with what CMake recommends in their tutotrials. Considering the simplicity of your project (one library), the simplest solution is to put the CMake package config file alongside the target file and just include it.
Let me know whether you have any questions.