Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag 2.1.3 fails to build on Windows #234

Closed
j-o opened this issue May 22, 2017 · 6 comments
Closed

Tag 2.1.3 fails to build on Windows #234

j-o opened this issue May 22, 2017 · 6 comments

Comments

@j-o
Copy link

j-o commented May 22, 2017

Due to a bug in the CMake script, the gcc template API header containing __attribute__((visibility("default"))) is selected on Windows.

The bug is fixed on master, but maybe you should think about retracting that release or at least add this to the known issues.

@scheibel
Copy link
Member

Valid objection; I'll fix this.

@scheibel
Copy link
Member

scheibel commented Jul 4, 2017

I probably fixed this in the v2.1 branch. Can you verify the issue is fixed before I release 2.1.4?

@j-o
Copy link
Author

j-o commented Jul 11, 2017

Now I get this error during cmake configure:

CMake Error: File D:/projects/glbinding/source/codegeneration/template_msvc_api.h.in does not exist.
CMake Error at cmake/GenerateTemplateExportHeader.cmake:8 (configure_file):
  configure_file Problem configuring file
Call Stack (most recent call first):
  source/glbinding/CMakeLists.txt:176 (generate_template_export_header)

Commit 567f9de on master fixes that.
Shouldn't META_CMAKE_INIT_SHA be updated?

@amc522
Copy link

amc522 commented Feb 6, 2018

I too was running into the issue of failing to build 2.1.3 with msvc. I tested master and this is all seems fixed. Would it be possible to make a 2.1.4 tag so there is a stable release for windows? It would be nice to upgrade the version in vcpkg.

@scheibel
Copy link
Member

I just released glbinding-2.1.4 (https://github.com/cginternals/glbinding/releases/tag/v2.1.4). I hope everything is fixed.

@amc522
Copy link

amc522 commented Feb 22, 2018

Thanks! Just downloaded and built 2.1.4. Everything looks fine on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants