-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag 2.1.3 fails to build on Windows #234
Comments
Valid objection; I'll fix this. |
I probably fixed this in the v2.1 branch. Can you verify the issue is fixed before I release 2.1.4? |
Now I get this error during cmake configure:
Commit 567f9de on master fixes that. |
I too was running into the issue of failing to build 2.1.3 with msvc. I tested master and this is all seems fixed. Would it be possible to make a 2.1.4 tag so there is a stable release for windows? It would be nice to upgrade the version in vcpkg. |
I just released glbinding-2.1.4 (https://github.com/cginternals/glbinding/releases/tag/v2.1.4). I hope everything is fixed. |
Thanks! Just downloaded and built 2.1.4. Everything looks fine on windows. |
Due to a bug in the CMake script, the gcc template API header containing
__attribute__((visibility("default")))
is selected on Windows.The bug is fixed on master, but maybe you should think about retracting that release or at least add this to the known issues.
The text was updated successfully, but these errors were encountered: