-
Notifications
You must be signed in to change notification settings - Fork 27
Conversation
Does this look good @cgarwood? |
😬 so far behind on projects.. just merged your other PR and did a new release of the library, 0.0.9. Please update the requirements in manifest.json and give it a quick test then I think we're good to merge. |
@cgarwood Done! |
Hi @SamMousa , did you try to fix the format of your commit ? |
Not sure what you mean? I thought this one was done, but haven't looked at it in a long while! |
the check formatting action failed on some parts of the code you pushed : |
Yeah will do when I have time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some free time so I committed the code formatting changes 🙂
HACS validation test failure is unrelated to this PR
This depends on my PR here: cgarwood/python-fullykiosk#10
I've tested it to be working on my installation without modifying the underlying python library (harder to reach from vs-code plugin). To do that I just adapted the code from this PR to call existing function in
python-fullykiosk
directly.So instead of calling
enableMotionDetection
etc I did this:And instead of calling
getSettings
incoordinator.py
I did this:Again I don't speak python so check thoroughly!
This should also provide a simple framework for adding other switches for settings.