Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_loop and relax python version #7

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

cgarciae
Copy link
Owner

@cgarciae cgarciae commented Mar 16, 2023

Fixes #5
Fixes #6

  • Copies tasks at the start of train_loop to avoid stateful behaviour deleting tasks on subsequent runs during train_loop.
  • Update python version to >=3.8,<3.12
  • Restricts orbax version to <0.1.4 temporarily while key_path API stabilizes.

@cgarciae cgarciae changed the title Fix-test-loop+relax-python-version Fix test_loop and relax python version Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #7 (1ad983d) into main (f83c7f9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   77.89%   77.90%   +0.01%     
==========================================
  Files          12       12              
  Lines        1538     1539       +1     
==========================================
+ Hits         1198     1199       +1     
  Misses        340      340              
Impacted Files Coverage Δ
ciclo/loops/common.py 67.24% <100.00%> (+0.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cgarciae cgarciae merged commit ce3a24e into main Mar 16, 2023
@mstoelzle
Copy link

Great - thanks for the quick fix!! Both seems to be working now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation is only executed once in 02_mnist_train_loop.py example Python 3.11 support
2 participants