Adding missing encodings for CleartextCredentials and CustomLabel #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaik-jheher
reviewed
Nov 20, 2024
| @@ -1586,7 +1593,7 @@ Expand-Label(Secret, Label, Context, Length) = | |||
| Expand(Secret, CustomLabel, Length) | |||
| ~~~ | |||
|
|
|||
| Where CustomLabel is specified as: | |||
| Where CustomLabel is specified and encoded (following Section 3.4 of {{?RFC8446}}) as: | |||
There was a problem hiding this comment.
A reference to RFC8446 might potentially be overkill here.
You might also specify CustomLabel as the concatenation of I2OSP(Length, 2), I2OSP(len("OPAQUE-" + Label), 2), "OPAQUE-", Label, I2OSP(len(Context)), and Context. This would also match how Preamble is specified in 6.4.2.1.
There was a problem hiding this comment.
Thanks! I contemplated doing it this way, but ultimately decided that referencing the section in RFC8446 was a more concise way to describe the concatenation. Hope that this is still clear enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #469