Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to the Link component #234

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

alberturria
Copy link
Contributor

@alberturria alberturria commented Nov 6, 2023

Addition of unit tests to the Link component, in the same flavour as in these other tests

Changes

  • Links.test.tsx => Addition of file with the tests supporting:
  1. m-list__horizontal class is added to List when isHorizontal prop is passed in
  2. m-list__links class is added to List when isLinks prop is passed in
  3. m-list__spaced class is added to List when isSpaced prop is passed in
  4. m-list__unstyled class is added to List when isUnstyled prop is passed in
    1. list is rendered when isOrdered prop is passed in

    How to test this PR

    1. Run npm t Link.test.tsx

    Screenshots

    image

    Notes

    closes [Task] Create Tests for List Component #222

Copy link

netlify bot commented Nov 6, 2023

👷 Deploy request for cfpb-design-system-react pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a031073

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 Thanks for your work @alberturria! You're good to merge in: the Chromatic visual regression test is only failing since you're not part of our org, so don't worry about that failing status check when you're merging.

Would you be interested in some more testing related PRs? Maybe something a little more involved/fun like some behavioral tests for a more complicated component? I'm happy to write up a new issue for you, and work with you if you have any questions.

Thanks again @alberturria! We appreciate your contribution, and let me know if you'd like to stay involved! 🎉

@alberturria
Copy link
Contributor Author

Looks great! 👍 Thanks for your work @alberturria! You're good to merge in: the Chromatic visual regression test is only failing since you're not part of our org, so don't worry about that failing status check when you're merging.

Would you be interested in some more testing related PRs? Maybe something a little more involved/fun like some behavioral tests for a more complicated component? I'm happy to write up a new issue for you, and work with you if you have any questions.

Thanks again @alberturria! We appreciate your contribution, and let me know if you'd like to stay involved! 🎉

Thank you @billhimmelsbach !
Definitively I would love to contribute on something else within this repo 🙂.
Feel free to assign any other issue to me 💪 .

@alberturria
Copy link
Contributor Author

Btw @billhimmelsbach feel free to merge this PR once the CI passes again 🙂
Sorry, but main got updated and I needed to update my base branch again (blocking me to actually merge this PR 😢 )

@billhimmelsbach
Copy link
Contributor

Heyo! Will do @alberturria! I'm going to work up a more interesting ticket for you too soon. 👍

@billhimmelsbach billhimmelsbach enabled auto-merge (squash) November 21, 2023 21:19
@billhimmelsbach billhimmelsbach merged commit ac14b10 into cfpb:main Nov 21, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Create Tests for List Component
2 participants