-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to the Link
component
#234
Conversation
👷 Deploy request for cfpb-design-system-react pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍 Thanks for your work @alberturria! You're good to merge in: the Chromatic visual regression test is only failing since you're not part of our org, so don't worry about that failing status check when you're merging.
Would you be interested in some more testing related PRs? Maybe something a little more involved/fun like some behavioral tests for a more complicated component? I'm happy to write up a new issue for you, and work with you if you have any questions.
Thanks again @alberturria! We appreciate your contribution, and let me know if you'd like to stay involved! 🎉
Thank you @billhimmelsbach ! |
Btw @billhimmelsbach feel free to merge this PR once the CI passes again 🙂 |
Heyo! Will do @alberturria! I'm going to work up a more interesting ticket for you too soon. 👍 |
Addition of unit tests to the
Link
component, in the same flavour as in these other testsChanges
list is rendered when isOrdered prop is passed in
How to test this PR
npm t Link.test.tsx
Screenshots
Notes
closes [Task] Create Tests for List Component #222