Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Storybook] Improve readability of code blocks #220

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix: [Storybook] Improve readability of code blocks #220

merged 1 commit into from
Oct 27, 2023

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Oct 26, 2023 •
edited
Loading

Closes #214

Changes

  • Make code blocks' font white
  • Increase code blocks' font size
  • Increase code blocks' line height

How to test this PR

  1. Visit deployed preview
  2. Click Show Code for a Story
  3. Observe

Screenshots

Screenshot 2023-10-26 at 3 34 41 PM

Notes

  • There's a two year old issue in Storybook to enable users to change the theme used for syntax highlighting but it doesn't have much traction, so this is our workaround.

@netlify
Copy link

netlify bot commented Oct 26, 2023 •
edited
Loading

✅ Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 94623ac
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/653adbf0f7459700077c0e22
😎 Deploy Preview https://deploy-preview-220--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

billhimmelsbach
billhimmelsbach approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@meissadia meissadia merged commit c0678a2 into main Oct 27, 2023
9 checks passed
@meissadia meissadia deleted the 214-bug-unreadable-code branch October 27, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach billhimmelsbach approved these changes

@shindigira shindigira Awaiting requested review from shindigira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Storybook] Codeblock plain text unreadable
2 participants
@meissadia @billhimmelsbach