-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Component] Verify Tagline Component #205
Comments
This was referenced Oct 19, 2023
billhimmelsbach
added a commit
that referenced
this issue
Oct 26, 2023
I went through and [verified the Tagline component](#205) as part of the work on the banner component. Only small changes to the documentation appear to be needed. I didn't add the deprecated "Extra large tagline" story from the design system, since it was deprecated and all, but we can chat about that at the DSR sync. ## Changes - add component description - remove heading - change stories to sentence case ## How to test this PR 1. Take a peek at the DSR and see how it looks ## Screenshots ![Screenshot 2023-10-19 at 9 48 05 AM](https://github.com/cfpb/design-system-react/assets/19983248/684c015c-bd8d-4a6c-b054-0fdb1158c7e0) ## Notes I didn't mark this component as "verified" in this PR, since I'm not sure if we have an official stamp of approval process yet, so I'll hold off till at least we chat about it at the sync.
meissadia
pushed a commit
that referenced
this issue
Oct 26, 2023
I went through and [verified the Tagline component](#205) as part of the work on the banner component. Only small changes to the documentation appear to be needed. I didn't add the deprecated "Extra large tagline" story from the design system, since it was deprecated and all, but we can chat about that at the DSR sync. ## Changes - add component description - remove heading - change stories to sentence case ## How to test this PR 1. Take a peek at the DSR and see how it looks ## Screenshots ![Screenshot 2023-10-19 at 9 48 05 AM](https://github.com/cfpb/design-system-react/assets/19983248/684c015c-bd8d-4a6c-b054-0fdb1158c7e0) ## Notes I didn't mark this component as "verified" in this PR, since I'm not sure if we have an official stamp of approval process yet, so I'll hold off till at least we chat about it at the sync.
21 tasks
billhimmelsbach
added a commit
that referenced
this issue
Nov 7, 2023
Resolves #205 # Final Design Review of Tagline Component ![Screenshot 2023-10-26 at 9 48 38 AM](https://github.com/cfpb/design-system-react/assets/19983248/68841dad-cacc-43ff-ad15-a0ac1f337da5) [Link to Tagline Component in this PR](https://deploy-preview-218--cfpb-design-system-react.netlify.app/?path=/docs/components-verified-taglines--overview) Previous work on component: #207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Verify banner component to be used in the component library
Context
Verification checklist
For existing components
Verify the CFPB Design System (React) component against the CFPB Design System
Run accessibility checks
Verify component unit tests
yarn vitest Button
)Conduct PR review
Verify component
The text was updated successfully, but these errors were encountered: