Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to README about suppressing JSLint in Brackets 1.1 #68

Open
njx opened this issue Dec 18, 2014 · 11 comments
Open

Add note to README about suppressing JSLint in Brackets 1.1 #68

njx opened this issue Dec 18, 2014 · 11 comments

Comments

@njx
Copy link

njx commented Dec 18, 2014

Before Brackets 1.1, I think the JSHint extension automatically suppressed JSLint errors. In 1.1, with the new multiple linter support, JSLint errors started showing up again. It might be good to put a note in your README about adding the proper preference to .brackets.json to re-suppress the JSLint errors:

    "language": {
        "javascript": {
            "linting.prefer": "JSHint",
            "linting.usePreferredOnly": true
        }
    }

Or maybe there's a way you could set that preference programmatically by default (though you'd have to make sure that the user's own .brackets.json would properly override that).

@fpirsch
Copy link

fpirsch commented Dec 18, 2014

👍

@imrefazekas
Copy link

Based on the API of brackets, when you registers a new linting tool, it should suppress the built-in one:
" unregisters the built-in Brackets JSLint provider."

http://brackets.io/docs/current/modules/language/CodeInspection.html

The plugin does not call this or it does not work properly?

@busykai
Copy link
Contributor

busykai commented Dec 19, 2014

It does not suppress the default provider (JSLint). You have to do it manually. I will update the documentation in the code.

@driskull
Copy link

@njx thanks for this. I was wondering how to turn JSLint off. 🍺

@tshak
Copy link

tshak commented Dec 20, 2014

👍

@cfjedimaster
Copy link
Owner

@njx would this be a bug for Brackets: Open file.js. I see JSLint and JSHint results in the panel. I click the caret to close JSLint results. I select another file. I go back to file.js and the JSLint stuff is expanded again.

@cfjedimaster
Copy link
Owner

I added a note to the readme.

@blah238
Copy link

blah238 commented Dec 22, 2014

This doesn't seem to work on Windows, still getting both JSLint and JSHint warnings.

Update: Never mind, it works. I just needed to wrap it in another set of braces:

{
  "language": {
    "javascript": {
      "linting.prefer": "JSHint",
      "linting.usePreferredOnly": true
    }
  }
}

@fpirsch
Copy link

fpirsch commented Dec 22, 2014

@njx's code can be pasted in the preference file. You can open it from within Brackets under the Debug menu.

@njx
Copy link
Author

njx commented Jan 5, 2015

@cfjedimaster: yes, we should remember the state - definitely worth filing.

@cfjedimaster
Copy link
Owner

Done - adobe/brackets#10316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants