Make JSLint pre-installed extension instead of default

[core-ai-bot]

Issue by busykai
Monday Jan 05, 2015 at 20:10 GMT
Originally opened as adobe/brackets#10317

---

With landing of support for multiple linters, the developers seem to struggle with sudden appearance of JSLint in their linting results. Special care should be made (such as cfjedimaster/brackets-jshint#68) to suppress JSLint.

A normal workflow for a linter is

1. Install extension
2. Try extension
3. Uninstall extension (in case it does not suit the needs).

For JSLint, being default extension, item 3 (as well as item 1) is not an option, but it should be to make it on par with any other CodeInspection providers.

A most reasonable solution is to make JSLint a pre-installed extension (also available via Brackets registry). It would then come by default to any Brackets developer and could be installed/uninstalled by any other developer at will.

[core-ai-bot]

Comment by spocke
Thursday Jan 08, 2015 at 10:43 GMT

---

I second this since since this is the config I'm now forced to add to all installations of Brackets:

"language": {
    "javascript": {
        "linting.prefer": ["JSHint", "ESLint", "JSCS"],
        "linting.usePreferredOnly": true
      }
}

So if you are using all kinds of linters except "jslint" you need to manually add them to the prefer list to skip the internal JSLint package. I suggest not having any linting in there what so ever by and let the user manually install the linter packages they prefer.

[core-ai-bot]

Comment by MarcelGerber
Monday Jan 12, 2015 at 14:57 GMT

---

Probably the biggest problem with a pre-installed extension is that it auto-updates on first start of a new Brackets version. Normally, that's a great thing, but AFAICT it will make deinstallation unnecessarily hard. Take this as an example:

1. User installs Brackets 1.0 with JSLint 1.0
2. JSLint 1.0 installs itself
3. User uninstalls JSLint 1.0
4. User installs Brackets 1.1 with JSLint 1.1
5. JSLint 1.1 installs itself (I'm not quite sure about this, but I think that's what happens)
6. User has to uninstall JSLint 1.1 again

[core-ai-bot]

Comment by redmunds
Monday Jan 12, 2015 at 16:05 GMT

---

@MarcelGerber

1. JSLint 1.1 installs itself (I'm not quite sure about this, but I think that's what happens)

It should not work that way. Once you uninstall an "bundled" extension, Brackets should not install a newer version. But I'd like to avoid adding extensions to the bundle if possible as this is extra work when building the installers.

@busykai Another solution would be to make Linting disabled by default and the projects such as Brackets can enable it in their project preferences.

[core-ai-bot]

Comment by busykai
Monday Jan 12, 2015 at 16:48 GMT

---

@redmunds, yes, we can opt for disabling JSLint by default. I think that ultimately though, we need to remove any special treatment of it and make it on-par with the rest of the CodeInspection providers for JS (and use linting.prefer et al. as a single place for provider management). I can see how disabling could be equally confusing for the folks who actually use it (besides Brackets).

Anyways, if removing it from the repo would take long time, we should probably go for disabling.

[core-ai-bot]

Comment by cfjedimaster
Tuesday Mar 10, 2015 at 13:16 GMT

---

+1 to the idea of making it 'not special' and just like any other extension (although I do think it is nice to keep it pre-installed).

[core-ai-bot]

Comment by zeet2020
Wednesday Nov 30, 2016 at 08:44 GMT

---

+1 its good idea, to have jsLint pre-installed.