Skip to content

Conversation

@victormlg
Copy link
Contributor

Depends on:
#151
#152

@cf-bottom
Copy link

Thank you for submitting a pull request! Maybe @larsewi can review this?

@victormlg victormlg marked this pull request as ready for review August 22, 2025 11:19
@victormlg victormlg requested a review from larsewi August 22, 2025 11:19
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can skip printing the setup code with demo option, given that the demo option completes the setup.

$ cf-remote --version master install --demo --bootstrap hub --hub hub
 ---snip---
##########################################################################
CFEngine Mission Portal first time setup:

Navigate to Mission Portal in your browser (using the hub's IP / hostname)
and enter the setup code below when prompted for it:

Setup code: 930816

Note: This code will expire in one hour or after 5 unsuccessful attempts,
if needed, run 'cf-hub --new-setup-code' again on the hub for a new code.
##########################################################################
 ---snip---

What happens if you install an older version of CFEngine that does not have a first time setup?

@victormlg victormlg force-pushed the demo-admin2 branch 2 times, most recently from 19ca3be to 3d8bcd8 Compare August 27, 2025 09:25
@victormlg
Copy link
Contributor Author

Maybe you can skip printing the setup code with demo option, given that the demo option completes the setup.

$ cf-remote --version master install --demo --bootstrap hub --hub hub
 ---snip---
##########################################################################
CFEngine Mission Portal first time setup:

Navigate to Mission Portal in your browser (using the hub's IP / hostname)
and enter the setup code below when prompted for it:

Setup code: 930816

Note: This code will expire in one hour or after 5 unsuccessful attempts,
if needed, run 'cf-hub --new-setup-code' again on the hub for a new code.
##########################################################################
 ---snip---

What happens if you install an older version of CFEngine that does not have a first time setup?

It looks like it works fine for order version of cfengine

@victormlg victormlg requested a review from larsewi August 27, 2025 09:26
Ticket: ENT-13007
Signed-off-by: Victor Moene <[email protected]>
Changelog: This is unecessary and cause confict with sql query
Signed-off-by: Victor Moene <[email protected]>
@larsewi larsewi requested a review from olehermanse August 27, 2025 11:39
@olehermanse olehermanse merged commit ad3e7eb into cfengine:master Aug 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants