CFE-4405: Added curl installation check when remote download #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehermanse
reviewed
Apr 24, 2025
victormlg
force-pushed
the
curl_not_installed
branch
from
06b1b00 to
235622e
Compare
olehermanse
requested changes
Apr 25, 2025
victormlg
force-pushed
the
curl_not_installed
branch
from
235622e to
cfa439e
Compare
| if remote_download: | ||
| if data.get("bin") and not data.get("bin", {}).get("curl"): | ||
| log.error( | ||
| "Couldn't download remotely. Curl is not installed on host '%s'" % host |
There was a problem hiding this comment.
Is there also a fix for curl not being installed on the cf-remote host? I ran into this today and cf-remote just seemed to "hang" for a long time without curl installed (in a debian-12 container fwiw).
There was a problem hiding this comment.
I think this pr should already solve this problem. I didn't see curl used anywhere else on the remote host
There was a problem hiding this comment.
@victormlg I think he meant on the machine you're running cf-remote on, not the remote. There is one more place where we use curl, in disable_password_dialog. Maybe that's what he was referring to.
larsewi
reviewed
May 12, 2025
Ticket: CFE-4405 Signed-off-by: Victor Moene <[email protected]>
victormlg
force-pushed
the
curl_not_installed
branch
from
cfa439e to
db6b5c2
Compare
olehermanse
approved these changes
May 15, 2025
olehermanse
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.