Skip to content

Fixed error when not specifying a username in host parameter #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Fixed error when not specifying a username in host parameter #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b3299d
Added test of info command without username in the docker test
craigcomstock Feb 21, 2025
8f0af0c
Fixed error when not specifying a username in host parameter
craigcomstock Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cf_remote/ssh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def connect(host, users=None):
log.debug("users= '%s'" % users)
parts = urlparse("ssh://%s" % host)
host = parts.hostname
if not users:
if not users and parts.username:
users = [parts.username]
port = parts.port or aramid._DEFAULT_SSH_PORT
if not users:
Expand Down
2 changes: 2 additions & 0 deletions tests/docker/001-docker-install-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ echo "ssh returned exit code $?"
echo "=== cf-remote info ===" | tee -a log
cf-remote --log-level DEBUG info -H root@"$ip_addr":8822 2>&1 | tee -a log
echo "cf-remote info got return code $?"
cf-remote --log-level DEBUG info -H "$ip_addr":8822 2>&1 | tee -a log
echo "cf-remote info got return code $?"
echo "=== cf-remote install ===" | tee -a log
cf-remote --log-level DEBUG install --clients root@"$ip_addr":8822 2>&1 | tee -a log
ssh -o StrictHostKeyChecking=no -p 8822 root@"$ip_addr" cf-agent -V >>log 2>&1
Loading