Update usage of false_easting and false_northing in projections #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erget
reviewed
Jan 8, 2020
Member
erget
left a comment
erget
left a comment
There was a problem hiding this comment.
Content looks fine, I've requested 2 formatting changes to be able to trace changes better moving forward.
appf.adoc
Outdated
| coordinates for a map projection in order to eliminate negative numbers. Expressed in | ||
| the unit of the coordinate variable identified by the | ||
| standard name **`projection_x_coordinate`**. | ||
| standard name **`projection_x_coordinate`**. If |
Member
There was a problem hiding this comment.
@neumannd could you move this sentence onto its own line (and on line 449) so it's one sentence, one line?
In source code it makes sense to restrict line length, but for a document like the Conventions it makes it easier to compare changes if each sentence stands on its own line. Then a blame doesn't produce false positives. We don't need to reflow all the text in the documents but when we touch or add a sentence I think it's best to put them on their own line.
Contributor
Author
|
@erget: Thanks for the info. I updated the text accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The projection parameters
false_eastingandfalse_northingshould be considered as optional for all projections. If they do not exist, they should be assumed to be0. This was added to the definitions of these parameters.See issue #212 for discussion of these changes.