Fix panic when comparing ropes with chunks that do not align at char bounds #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
reviewed
Oct 26, 2022
pascalkuthe
force-pushed
the
non_ascii_comparison
branch
from
832e41e
to
6c1c50e
Compare
pascalkuthe
force-pushed
the
non_ascii_comparison
branch
from
6c1c50e
to
cc516d5
Compare
|
Awesome! Thanks for catching this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development of helix-editor/helix#3890, @xJonathanLEI provided a test case that would cause a panic in ropey.
It turns out that
PartialEqforRopeSliceindexes into astrusing byte indices that might not be char bounds.The fix for this issue was to simply operate on byte slices directly.
The very similar
PartialOrdimplementation has received the same treatment in the past butPartialEqseems to have been overlooked.